From owner-svn-src-all@FreeBSD.ORG  Wed Jan 11 00:47:07 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1233)
	id 81B63106566C; Wed, 11 Jan 2012 00:47:07 +0000 (UTC)
Date: Wed, 11 Jan 2012 00:47:07 +0000
From: Alexander Best <arundel@freebsd.org>
To: Dimitry Andric <dim@FreeBSD.org>
Message-ID: <20120111004707.GA76892@freebsd.org>
References: <201201100258.q0A2wT7E079753@svn.freebsd.org>
	<20120110082106.GD1801@garage.freebsd.pl>
	<4F0C0714.6060501@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F0C0714.6060501@FreeBSD.org>
Cc: svn-src-head@freebsd.org, Eitan Adler <eadler@FreeBSD.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>
Subject: Re: svn commit: r229908 - head/usr.bin/brandelf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2012 00:47:07 -0000

On Tue Jan 10 12, Dimitry Andric wrote:
> On 2012-01-10 09:21, Pawel Jakub Dawidek wrote:
> >On Tue, Jan 10, 2012 at 02:58:29AM +0000, Eitan Adler wrote:
> >>Author: eadler (ports committer)
> >>Date: Tue Jan 10 02:58:29 2012
> >>New Revision: 229908
> >>URL: http://svn.freebsd.org/changeset/base/229908
> >>
> >>Log:
> >>   Fix warning when compiling with gcc46:
> >>   	 error: variable 'verbose' set but not use
> >
> >Maybe we should remove -v from the manual page as well or document as 
> >no-op?
> >I'd still leave it in the code though, so there is no POLA violation.
> 
> It has been a no-op since the beginning of brandelf, and I have really
> no idea what the original author intended the verbose output to be. :)
> 
> It is probably best to document it as a no-op now, to reduce possible
> confusion.

shouldn't brandelf be replaced with the version from the elftoolchain project?
any news when the first import is going to happen?

cheers.
alex