Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Jan 2004 12:48:56 -0500 (EST)
From:      Robert Watson <rwatson@freebsd.org>
To:        Pawel Jakub Dawidek <nick@garage.freebsd.pl>
Cc:        phk@freebsd.org
Subject:   Re: MD(4) cleanups and unload lesson.
Message-ID:  <Pine.NEB.3.96L.1040111124747.91469c-100000@fledge.watson.org>
In-Reply-To: <20040111155842.GB74246@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help

On Sun, 11 Jan 2004, Pawel Jakub Dawidek wrote:

> With attached patch unloading md(4) module is possible.  It also cleans
> up big part of code according to style(9). 

Could you separate this into a functional diff and a style diff?  There's
a general preference to not combine them, as it means cvs diff between
revisions isn't useful for identifying functional changes (i.e., reviewing
for bugs when back-tracking, etc). 

Thanks,

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Senior Research Scientist, McAfee Research




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1040111124747.91469c-100000>