Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Aug 2017 09:28:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 221848] sys/conf/newvers.sh: Only accept git-svn-id: attributes at the start of the line
Message-ID:  <bug-221848-8@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221848

            Bug ID: 221848
           Summary: sys/conf/newvers.sh: Only accept git-svn-id:
                    attributes at the start of the line
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch, regression
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: fk@fabiankeil.de
             Flags: mfc-stable10?, mfc-stable11?

Created attachment 185801
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185801&action=
=3Dedit
sys/conf/newvers.sh: Only accept git-svn-id: attributes at the start of the
line

The attached patch lets sys/conf/newvers.sh only accept "git-svn-id:"
attributes at the start of the line.

This prevents incorrect subversion revision detection if "git svn" isn't be=
ing
used to get the sources but git is available. Previously old subversion
revisions
included in commit messages were favoured over the more recent and correct
revisions in the "Notes:" section.

For example cf1f35574722 represents r315395 but was treated as r313908 which
is referenced in the commit message. Commits following r315395/cf1f35574722
but before another commit with a git-svn-id reference in the commit message
would be treated as r313908 as well.

Obtained from: ElectroBSD

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221848-8>