From owner-freebsd-bugs@freebsd.org Sun Aug 27 09:28:21 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BEBB8DEB8F1 for ; Sun, 27 Aug 2017 09:28:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A167C6BE3D for ; Sun, 27 Aug 2017 09:28:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7R9SLuQ038102 for ; Sun, 27 Aug 2017 09:28:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 221848] sys/conf/newvers.sh: Only accept git-svn-id: attributes at the start of the line Date: Sun, 27 Aug 2017 09:28:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fk@fabiankeil.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable10? mfc-stable11? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Aug 2017 09:28:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221848 Bug ID: 221848 Summary: sys/conf/newvers.sh: Only accept git-svn-id: attributes at the start of the line Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Keywords: patch, regression Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: fk@fabiankeil.de Flags: mfc-stable10?, mfc-stable11? Created attachment 185801 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185801&action= =3Dedit sys/conf/newvers.sh: Only accept git-svn-id: attributes at the start of the line The attached patch lets sys/conf/newvers.sh only accept "git-svn-id:" attributes at the start of the line. This prevents incorrect subversion revision detection if "git svn" isn't be= ing used to get the sources but git is available. Previously old subversion revisions included in commit messages were favoured over the more recent and correct revisions in the "Notes:" section. For example cf1f35574722 represents r315395 but was treated as r313908 which is referenced in the commit message. Commits following r315395/cf1f35574722 but before another commit with a git-svn-id reference in the commit message would be treated as r313908 as well. Obtained from: ElectroBSD --=20 You are receiving this mail because: You are the assignee for the bug.=