Date: Wed, 7 Jan 2015 23:05:59 -0800 From: John-Mark Gurney <jmg@funkthat.com> To: Julian Elischer <julian@freebsd.org> Cc: Craig Rodrigues <rodrigc@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, Nikos Vassiliadis <nvass@gmx.com>, Gleb Smirnoff <glebius@freebsd.org>, svn-src-head@freebsd.org, "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Subject: Re: svn commit: r276747 - head/sys/netpfil/pf Message-ID: <20150108070558.GA1949@funkthat.com> In-Reply-To: <54ADFB88.1090705@freebsd.org> References: <201501060903.t06934qp081875@svn.freebsd.org> <20150107204631.GG15484@FreeBSD.org> <AEFC5AEF-7700-426A-96D3-A14BF68CA9BC@lists.zabbadoz.net> <20150108003146.GL15484@FreeBSD.org> <54ADFB88.1090705@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote this message on Thu, Jan 08, 2015 at 11:37 +0800: > On 1/8/15 8:31 AM, Gleb Smirnoff wrote: > > On Thu, Jan 08, 2015 at 12:21:57AM +0000, Bjoern A. Zeeb wrote: > > B> > > B> > On 07 Jan 2015, at 20:46 , Gleb Smirnoff <glebius@freebsd.org> wrote: > > B> > > > B> > On Tue, Jan 06, 2015 at 09:03:04AM +0000, Craig Rodrigues wrote: > > B> > C> Author: rodrigc > > B> > C> Date: Tue Jan 6 09:03:03 2015 > > B> > C> New Revision: 276747 > > B> > C> URL: https://svnweb.freebsd.org/changeset/base/276747 > > B> > C> > > B> > C> Log: > > B> > C> Instead of creating a purge thread for every vnet, create > > B> > C> a single purge thread and clean up all vnets from this thread. > > B> > C> > > B> > C> PR: 194515 > > B> > C> Differential Revision: D1315 > > B> > C> Submitted by: Nikos Vassiliadis <nvass@gmx.com> > > B> > > > B> > I am not sure that this is a good idea. The core idea of VNETs > > B> > is that they are isolated from each other. If we serialize purging, > > B> > then vnets are strongly affecting each other. > > B> > > > B> > AFAIU, from the PR there is some panic fixed. What is the actual bug > > B> > and why couldn't it be fixed with having per-vnet thread? > > B> > > B> You don???t 30000 whatever pf purging threads on a system all running, possibly competing for some resources, e.g., locks? > > > > Isn't a vnet, which is a jail, already a set of a dozen of processes? So, > > if you are speaking of "30000 whatever pf purging threads", then you > > already mean "1 mln whatever processes". > Actually, no. > as we have presetned it, a vnet is part of a jail. > But, it was originally an independnent > thing, like FIBS, and a jail may exist with a single process. > I think one should be enough.. or if that it is not sufficient, then > at maximum, one per cpu We really need to make a library that handles creating/scheduling things like these better so people aren't reinventing them over and over again.. We do this in geli for creating threads for each geli worker... Can't something like taskqueue_start_threads_pinned be used for this? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150108070558.GA1949>