Date: Mon, 05 Nov 2018 11:25:40 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Craig Leres <leres@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r484114 - head/www/mini_httpd Message-ID: <pnvj-6ct7-wny@FreeBSD.org> In-Reply-To: <20181105100738.6jividegimmgmmgw@atuin.in.mat.cc> (Mathieu Arnold's message of "Mon, 5 Nov 2018 11:07:38 %2B0100") References: <201811041750.wA4Horts058612@repo.freebsd.org> <20181105100738.6jividegimmgmmgw@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Mathieu Arnold <mat@FreeBSD.org> writes: > On Sun, Nov 04, 2018 at 05:50:53PM +0000, Craig Leres wrote: > >> Author: leres >> Date: Sun Nov 4 17:50:52 2018 >> New Revision: 484114 >> URL: https://svnweb.freebsd.org/changeset/ports/484114 >> >> Log: >> Create log directory on install so that it exists when >> 500.mini_httpd-rotate runs. >> >> While we're here quiet new portlint nit (move CPE_VENDOR to its own >> block). > > Once again, portlint is getting it wrong, CPE_VENDOR was just fine where it was. > > https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-uses.html Maybe the handbook should document to not blindly trust portlint output. ;) Some committers (e.g., mainly those that use svn directly) land fixes and unrelated style clean ups in the same commit. Those are hard to review because getting style wrong may discourage functional fixes and if there're no other issues the whole review is nitpicking.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?pnvj-6ct7-wny>