From owner-freebsd-net@FreeBSD.ORG  Wed May 26 20:00:44 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DB7FE1065670
	for <freebsd-net@freebsd.org>; Wed, 26 May 2010 20:00:44 +0000 (UTC)
	(envelope-from robin@icir.org)
Received: from fruitcake.ICSI.Berkeley.EDU (fruitcake.ICSI.Berkeley.EDU
	[192.150.186.11])
	by mx1.freebsd.org (Postfix) with ESMTP id C4B9F8FC16
	for <freebsd-net@freebsd.org>; Wed, 26 May 2010 20:00:44 +0000 (UTC)
Received: from empire.icsi.berkeley.edu (empire.ICSI.Berkeley.EDU
	[192.150.186.169])
	by fruitcake.ICSI.Berkeley.EDU (8.12.11.20060614/8.12.11) with ESMTP id
	o4QK0iT0014855; Wed, 26 May 2010 13:00:44 -0700 (PDT)
Received: by empire.icsi.berkeley.edu (Postfix, from userid 502)
	id 35CFA1FE6EB; Wed, 26 May 2010 13:00:44 -0700 (PDT)
Date: Wed, 26 May 2010 13:00:44 -0700
From: Robin Sommer <robin@icir.org>
To: Jack Vogel <jfvogel@gmail.com>
Message-ID: <20100526200044.GA80693@icir.org>
References: <20100514180151.GA8175@icir.org> <20100519042100.GB6390@icir.org>
	<AANLkTinULZyQ1_KdMdh1qtfE0DTq_pLKndpfaPUAzAuJ@mail.gmail.com>
	<20100519162032.GE6390@icir.org>
	<AANLkTilpnt6uqeWXHLiNwrrpaXGCTpuvP5KxigICcQqf@mail.gmail.com>
	<20100525190310.GB32901@icir.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100525190310.GB32901@icir.org>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: freebsd-net@freebsd.org
Subject: Re: Crashes with ixgbe on FreeBSD 8
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 May 2010 20:00:44 -0000


On Tue, May 25, 2010 at 12:03 -0700, I wrote:

> /usr/src/sys/dev/ixgbe/ixgbe.c:833: warning: implicit declaration of function 'drbr_needs_enqueue'

So, I've now simply copied that function over and, indeed, that not
only compiles but gives me a working 2.2.0 driver, enabling me to
capture traffic in a stable fashion as far as I can tell so far ...

My question: is simply pasting this function into RELEASE a
reasonable fix, or am I missing out on further changes and am thus
getting myself into trouble in some form?

Robin

-- 
Robin Sommer * Phone +1 (510) 666-2886 * robin@icir.org 
ICSI/LBNL    * Fax   +1 (510) 666-2956 *   www.icir.org