From owner-freebsd-current@FreeBSD.ORG Sun Jun 19 22:27:57 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7D8116A41C; Sun, 19 Jun 2005 22:27:57 +0000 (GMT) (envelope-from dwhite@gumbysoft.com) Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF27043D53; Sun, 19 Jun 2005 22:27:57 +0000 (GMT) (envelope-from dwhite@gumbysoft.com) Received: by carver.gumbysoft.com (Postfix, from userid 1000) id B0EF972DD4; Sun, 19 Jun 2005 15:27:57 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by carver.gumbysoft.com (Postfix) with ESMTP id AEAF672DCB; Sun, 19 Jun 2005 15:27:57 -0700 (PDT) Date: Sun, 19 Jun 2005 15:27:57 -0700 (PDT) From: Doug White To: David O'Brien In-Reply-To: <20050617083507.GA3061@dragon.NUXI.org> Message-ID: <20050619152736.U83634@carver.gumbysoft.com> References: <20050613192308.GA87640@sandvine.com> <20050614082039.GA2038@dragon.NUXI.org> <20050614224704.Y75797@mp2.macomnet.net> <20050614190854.GA12928@dragon.NUXI.org> <20050614235132.L76669@mp2.macomnet.net> <20050615023600.GA20721@dragon.NUXI.org> <20050615141447.GD95217@sandvine.com> <20050617083507.GA3061@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: freebsd-current@freebsd.org, Ed Maste Subject: Re: savecore(8) increments /var/crash/bounds on each boot X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2005 22:27:58 -0000 On Fri, 17 Jun 2005, David O'Brien wrote: > On Wed, Jun 15, 2005 at 10:14:47AM -0400, Ed Maste wrote: > > On Tue, Jun 14, 2005 at 07:36:00PM -0700, David O'Brien wrote: > > > Do you understand the fix? How does lying in printheader() fix anything? > > > Moving the call to getbounds() back to the original location is the "fix" > > > but then it negates -vv. We shouldn't lie in printheader(). > > > > Fair enough, on dwhite's suggestion here's another try that splits the > > increment-and-write out from getbounds() so that the bounds value can > > be shown with -vv. > ..snip.. > > --- savecore.c.orig 2005-06-13 16:19:41.000000000 -0400 > > +++ savecore.c 2005-06-15 09:41:52.000000000 -0400 > ... > > + writebounds(bounds+1); > ^^^^^^^^ > bounds + 1 > > I like the patch, after the style(9) fix. Might as well avoid a > brucification. ;-) Who's going to commit this patch? I'll get this committed. -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org