Date: Thu, 1 Mar 2001 21:53:53 +0200 (EET) From: Maxim Sobolev <sobomax@FreeBSD.ORG> To: rooneg@electricjellyfish.net (Garrett Rooney) Cc: sobomax@FreeBSD.ORG (Maxim Sobolev), ports@FreeBSD.ORG, jhk@FreeBSD.ORG, gad@FreeBSD.ORG, reg@FreeBSD.ORG Subject: Re: [patch] which package functionality for pkg_info Message-ID: <200103011954.f21Js4n59881@vic.sabbo.net> In-Reply-To: <20010301133020.A23453@electricjellyfish.net> from "Garrett Rooney" at Mar 01, 2001 01:30:20 PM
next in thread | previous in thread | raw e-mail | index | archive | help
> On Thu, Mar 01, 2001 at 07:55:24PM +0200, Maxim Sobolev wrote: > > Attached please find revised patch that uses matchinstalled() instead of fts > > loop. IMO the code looks much cleaner. I fixed several other issues as well > > (leak of opened file, useless snprintf(&a, strlen(b), b) useless include etc.). > > [snip] > > done! > > one more thing. i notice that matchinstalled() returns a null terminated > array of strings, but they don't seem to be being freed anywhere. should > they? No, matchinstalled() does it automagically if invoked several times. ;) > +.Op Fl W Ar filename Probably should be ".Op Fl W Ar filename ..." (-W accepts multiple arguments). Looks almost finished, I'll look if I can commit it tomorrow. Thanks! -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103011954.f21Js4n59881>