Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 04 Jun 2013 03:58:12 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        jpaetzel@freebsd.org
Subject:   ports/179287: [PATCH] games/euchre: Fix port, bad C++ code, add icons, docs, take maintainership
Message-ID:  <20130604015815.E89F654A@hub.freebsd.org>
Resent-Message-ID: <201306040200.r54200Z2004095@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179287
>Category:       ports
>Synopsis:       [PATCH] games/euchre: Fix port, bad C++ code, add icons, docs, take maintainership
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 04 02:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p3 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p3 FreeBSD 9.1-RELEASE-p3 #0: Mon Apr 29 18:27:25 UTC 2013
>Description:

- Bump portrevision
- Fix port
- Trim master sites
- Add Icons
- Trim desktop entry
- Add docs
- Fix bad C++ code
- Trim pkg-descr
- Take maintainership

Generated and tested manually, tested with port test and with RedPorts, with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130604010101-31643/

>Fix:

--- euchre-0.8_1.patch begins here ---
diff -ruN /usr/ports/games/euchre/Makefile ./Makefile
--- /usr/ports/games/euchre/Makefile	2013-06-02 18:54:36.000000000 +0200
+++ ./Makefile	2013-06-04 02:57:06.000000000 +0200
@@ -3,25 +3,46 @@
 
 PORTNAME=	euchre
 PORTVERSION=	0.8
+PORTREVISION=	1
 CATEGORIES=	games
-MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION}
+MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/${PORTNAME}-${PORTVERSION} \
+		SF/nemysisfreebsdp/:icons
+DISTFILES=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX} \
+		${PORTNAME}.png:icons
+EXTRACT_ONLY=	${PORTNAME}-${DISTVERSION}${EXTRACT_SUFX}
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Very popular card game with variable skill levels
 
-LICENSE=	GPLv2 # (or later)
+LICENSE=	GPLv2
 
 USE_GNOME=	gtk20
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--disable-silent-rules
 MAKE_JOBS_SAFE=	yes
 
-PLIST_FILES=	bin/euchre
+PLIST_FILES=	bin/${PORTNAME} \
+		share/pixmaps/${PORTNAME}.png
 
-DESKTOP_ENTRIES="Euchre" "" "" "${PORTNAME}" "" true
+PORTDOCS=	AUTHORS ChangeLog README TODO
+
+DESKTOP_ENTRIES="Euchre" "${COMMENT}" "${PORTNAME}" \
+		"${PORTNAME}" "Game;CardGame;" false
+
+.include <bsd.port.options.mk>
 
 post-patch:
 	@${REINPLACE_CMD} -e \
 		'/^AM_/s|-Werror||' ${WRKSRC}/configure
+	@${REINPLACE_CMD} -e 's|int)|long int)|g' \
+		${WRKSRC}/src/gui/callbacks.cpp ${WRKSRC}/src/lib/Game.cpp
+
+post-install:
+	${INSTALL_DATA} ${_DISTDIR}/${PORTNAME}.png ${PREFIX}/share/pixmaps
+
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/games/euchre/distinfo ./distinfo
--- /usr/ports/games/euchre/distinfo	2013-06-02 18:54:36.000000000 +0200
+++ ./distinfo	2013-06-04 02:51:24.000000000 +0200
@@ -1,2 +1,4 @@
 SHA256 (euchre-0.8.tar.gz) = c339d29ea6837f344b98134ecdd7aa52fb958454bd4dd6145430b197752ed78b
 SIZE (euchre-0.8.tar.gz) = 213490
+SHA256 (euchre.png) = 94b5b20412e4bddc84ad066070843a0a3dd9504fd99fa497d8f32739c610ee31
+SIZE (euchre.png) = 6563
diff -ruN /usr/ports/games/euchre/pkg-descr ./pkg-descr
--- /usr/ports/games/euchre/pkg-descr	2013-06-02 18:54:36.000000000 +0200
+++ ./pkg-descr	2013-04-06 19:43:53.000000000 +0200
@@ -1,3 +1,6 @@
-A very basic interpretation of the game 'Euchre.'
+Euchre is a card game played with the 9s, 10s, Jacks, Queens, Kings,
+and Aces of all 4 suits.  Each player is dealt 5 cards, leaving 4
+cards in the deck.  The top card of the remaining 4 is then turned
+over and this is the trump candidate.
 
 WWW: http://sourceforge.net/projects/euchre/
--- euchre-0.8_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130604015815.E89F654A>