From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Mar 22 12:30:02 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0377F1065670 for ; Tue, 22 Mar 2011 12:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B33118FC28 for ; Tue, 22 Mar 2011 12:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p2MCU13R017508 for ; Tue, 22 Mar 2011 12:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p2MCU16d017507; Tue, 22 Mar 2011 12:30:01 GMT (envelope-from gnats) Resent-Date: Tue, 22 Mar 2011 12:30:01 GMT Resent-Message-Id: <201103221230.p2MCU16d017507@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Frank Wall Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA801106564A for ; Tue, 22 Mar 2011 12:28:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id A96038FC13 for ; Tue, 22 Mar 2011 12:28:29 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2MCSTIP038394 for ; Tue, 22 Mar 2011 12:28:29 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p2MCSTI0038393; Tue, 22 Mar 2011 12:28:29 GMT (envelope-from nobody) Message-Id: <201103221228.p2MCSTI0038393@red.freebsd.org> Date: Tue, 22 Mar 2011 12:28:29 GMT From: Frank Wall To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/155779: [PATCH] mail/policyd2: fix RC script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2011 12:30:02 -0000 >Number: 155779 >Category: ports >Synopsis: [PATCH] mail/policyd2: fix RC script >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Mar 22 12:30:01 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Frank Wall >Release: 7.3-RELEASE-p2 >Organization: >Environment: FreeBSD 7.3-RELEASE-p2 FreeBSD 7.3-RELEASE-p2 #0: Mon Jul 12 19:23:19 UTC 2010 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 >Description: The RC script for mail/policyd2 is broken, because it interferes with other perl daemons. The problem is that procname="/usr/bin/perl" is specified. This will match most other perl daemons as well. So instead of stopping/restarting mail/policyd2, ALL your other perl daemons are going to be killed. Not exactly what I want if I try to stop mail/policyd2. IMHO this is a serious issue. The attached patch fixes this problem by replacing "procname" with "command_interpreter". >How-To-Repeat: 1. choose any perl daemon, for example net-mgmt/snmptt, and install it 2. start this perl daemon: # /usr/local/etc/rc.d/snmptt onestart Starting snmptt. # /usr/local/etc/rc.d/snmptt onestatus snmptt is running as pid 54922. 3. now check policyd2 daemon status # /usr/local/etc/rc.d/policyd2 onestatus policyd2 is running as pid 54921 54922. 4. You will recognize that the PID 54922 for policyd2 actually is the PID for your other pearl daemon, snmptt. This is wrong. >Fix: apply the patch Patch attached with submission follows: --- mail/policyd2/files/policyd2.sh.in.orig 2011-03-22 13:02:27.000000000 +0100 +++ mail/policyd2/files/policyd2.sh.in 2011-03-22 13:13:14.000000000 +0100 @@ -19,7 +19,7 @@ rcvar=`set_rcvar` command="%%LOCALBASE%%/bin/cbpolicyd" -procname="/usr/bin/perl" +command_interpreter="/usr/bin/perl" load_rc_config $name >Release-Note: >Audit-Trail: >Unformatted: