From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 26 00:50:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 878BBE1F for ; Tue, 26 Nov 2013 00:50:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 69AF02608 for ; Tue, 26 Nov 2013 00:50:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAQ0o0ME083287 for ; Tue, 26 Nov 2013 00:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAQ0o0ii083286; Tue, 26 Nov 2013 00:50:00 GMT (envelope-from gnats) Resent-Date: Tue, 26 Nov 2013 00:50:00 GMT Resent-Message-Id: <201311260050.rAQ0o0ii083286@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Daniel Lorch Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1667CB87 for ; Tue, 26 Nov 2013 00:43:20 +0000 (UTC) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id EAABD25C9 for ; Tue, 26 Nov 2013 00:43:19 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rAQ0hJLA081820 for ; Tue, 26 Nov 2013 00:43:19 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rAQ0hJu2081816; Tue, 26 Nov 2013 00:43:19 GMT (envelope-from nobody) Message-Id: <201311260043.rAQ0hJu2081816@oldred.freebsd.org> Date: Tue, 26 Nov 2013 00:43:19 GMT From: Daniel Lorch To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/184296: kBuild won't install on DragonFlyBSD due to hardcoded values in Makefile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 00:50:00 -0000 >Number: 184296 >Category: ports >Synopsis: kBuild won't install on DragonFlyBSD due to hardcoded values in Makefile >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 26 00:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Daniel Lorch >Release: DragonFlyBSD 3.4.3 >Organization: >Environment: DragonFly dfly 3.4-RELEASE DragonFly v.343-RELEASE #0: Wed Aug 28 09:47:40 UTC 2013 root@/usr/obj/src/sys/X86_64_GENERIC x86_64 >Description: kBuild won't install on DragonFlyBSD due to hardcoded OS string "freebsd" in the port's Makefile. DragonFlyBSD is using `dports', which is a port of the FreeBSD ports system. I am reporting the problem here ("upstream"), because I believe this is the right place to fix it. Note that `kBuild' builds perfectly fine on DragonFly BSD, but the `make install' will fail because it is looks for the wrong path names (namely "freebsd" instead of "dragonfly"). Additionally, the Makefile fails to recognize the `amd64' architecture. Here is an extract from `make install': ===> Installing for kBuild-0.1.9998 ===> Generating temporary packing list ===> Checking if devel/kBuild already installed install -s -o root -g wheel -m 555 /wrkdirs/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.x86_64/release/stage/usr/local/bin/kDepIDB /usr/local/bin install: /wrkdirs/devel/kBuild/work/kBuild-0.1.9998/out/freebsd.x86_64/release/stage/usr/local/bin/kDepIDB: No such file or directory *** Error code 71 Stop. make: stopped in /usr/dports/devel/kBuild ===> Cleaning for kBuild-0.1.9998 build of /usr/dports/devel/kBuild ended at Wed Aug 28 02:41:00 PDT 2013 The full log can be obtained here: http://leaf.dragonflybsd.org/~marino/boomlogs/kBuild-0.1.9998.log >How-To-Repeat: cd /usr/dports/devel/kBuild && make install >Fix: I would like to suggest the patch attached to be applied to /usr/ports/devel/kBuild/Makefile and I am looking forward to your esteemed feedback. Patch attached with submission follows: --- /usr/freebsd-ports/devel/kBuild/Makefile 2013-11-22 02:45:10.218246000 +0000 +++ Makefile 2013-11-26 00:36:50.105484000 +0000 @@ -29,6 +29,7 @@ AUTORECONF=${AUTORECONF} \ AUTOPOINT=true USE_GCC= any +KBUILD_TARGET= ${OPSYS:tl} KBUILD_BINS= kDepIDB kDepPre kObjCache kmk kmk_append kmk_ash kmk_cat \ kmk_chmod kmk_cmp kmk_cp kmk_echo kmk_expr kmk_gmake \ @@ -65,14 +66,14 @@ do-install: .for bin in ${KBUILD_BINS} - ${INSTALL_PROGRAM} ${WRKSRC}/out/freebsd.${KBUILD_ARCH}/release/stage${PREFIX}/bin/${bin} ${PREFIX}/bin + ${INSTALL_PROGRAM} ${WRKSRC}/out/${KBUILD_TARGET}.${KBUILD_ARCH}/release/stage${PREFIX}/bin/${bin} ${PREFIX}/bin .endfor ${MKDIR} ${DATADIR} - (cd ${WRKSRC}/out/freebsd.${KBUILD_ARCH}/release/stage${PREFIX}/share/kBuild && ${COPYTREE_SHARE} \* ${DATADIR}) + (cd ${WRKSRC}/out/${KBUILD_TARGET}.${KBUILD_ARCH}/release/stage${PREFIX}/share/kBuild && ${COPYTREE_SHARE} \* ${DATADIR}) .if !defined(NOPORTDOCS) ${MKDIR} ${DOCSDIR} .for doc in ${PORTDOCS} - ${INSTALL_DATA} ${WRKSRC}/out/freebsd.${KBUILD_ARCH}/release/stage${PREFIX}/share/doc/${PORTNAME}-${KBUILD_VERSION}/${doc} ${DOCSDIR} + ${INSTALL_DATA} ${WRKSRC}/out/${KBUILD_TARGET}.${KBUILD_ARCH}/release/stage${PREFIX}/share/doc/${PORTNAME}-${KBUILD_VERSION}/${doc} ${DOCSDIR} .endfor .endif >Release-Note: >Audit-Trail: >Unformatted: