Date: Tue, 18 Sep 2018 16:06:56 +0000 (UTC) From: Ed Maste <emaste@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r480034 - head/multimedia/openh264 Message-ID: <201809181606.w8IG6ucG007916@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: emaste (src committer) Date: Tue Sep 18 16:06:56 2018 New Revision: 480034 URL: https://svnweb.freebsd.org/changeset/ports/480034 Log: multimedia/openh264: add -znotext to LDFLAGS on i386, for lld Example error: /usr/bin/ld: error: can't create dynamic relocation R_386_32 against local symbol in readonly segment; recompile object files with -fPIC This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default. PR: 214864 Approved by: bapt Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D17179 Modified: head/multimedia/openh264/Makefile Modified: head/multimedia/openh264/Makefile ============================================================================== --- head/multimedia/openh264/Makefile Tue Sep 18 16:05:15 2018 (r480033) +++ head/multimedia/openh264/Makefile Tue Sep 18 16:06:56 2018 (r480034) @@ -24,6 +24,7 @@ MAKE_ARGS= PREFIX="${PREFIX}" \ CFLAGS_OPT="" CFLAGS_DEBUG="" ALL_TARGET= all PLIST_SUB= PORTVERSION="${PORTVERSION}" +LDFLAGS_i386= -Wl,-znotext OPTIONS_DEFINE= DEBUG PLUGINS TEST OPTIONS_DEFAULT=PLUGINS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809181606.w8IG6ucG007916>