From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Dec 18 13:00:11 2008
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B0C061065677
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 18 Dec 2008 13:00:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 8DAD58FC12
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 18 Dec 2008 13:00:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBID0BLc076894
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 18 Dec 2008 13:00:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBID0BM1076893;
	Thu, 18 Dec 2008 13:00:11 GMT (envelope-from gnats)
Resent-Date: Thu, 18 Dec 2008 13:00:11 GMT
Resent-Message-Id: <200812181300.mBID0BM1076893@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	"Andriy 'squirL' Tovstik" <andriy.tovstik@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0F2561065673
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu, 18 Dec 2008 12:57:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id F2F958FC16
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu, 18 Dec 2008 12:57:10 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mBICvAL7076161
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 18 Dec 2008 12:57:10 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id mBICvA07076160;
	Thu, 18 Dec 2008 12:57:10 GMT (envelope-from nobody)
Message-Id: <200812181257.mBICvA07076160@www.freebsd.org>
Date: Thu, 18 Dec 2008 12:57:10 GMT
From: "Andriy 'squirL' Tovstik" <andriy.tovstik@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: ports/129733: incorrect GEOM status report from check_geom nagios
	plugin
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2008 13:00:11 -0000


>Number:         129733
>Category:       ports
>Synopsis:       incorrect GEOM status report from check_geom nagios plugin
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 18 13:00:11 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Andriy 'squirL' Tovstik
>Release:        7.0,6,2,6,3,6.4
>Organization:
redtram.com
>Environment:
>Description:
port /usr/ports/net-mgmt/nagios-geom/ has an error in GEOM status check. it returns OK status even if status of mirror is DEGRADED because sequence of logical operator is wrong
>How-To-Repeat:
# gmirror status
      Name    Status  Components
mirror/gm1  DEGRADED  ad4
# /usr/local/libexec/nagios/check_geom mirror gm1
OK mirror/gm1 DEGRADED { ad4 }|geom_mirror=1;;;0;
>Fix:
92c92
< if ( ( $class eq "mirror" || $class eq "raid3" ) && $status =~ /COMPLETE/ ) {
---
> if ($class eq "mirror" || $class eq "raid3" && $status =~ /COMPLETE/ ) {
96c96
< if ( ( $class eq "stripe" || $class eq "concat" || $class eq "shsec" ) && $status =~ /UP/) {
---
> if ($class eq "stripe" || $class eq "concat" || $class eq "shsec" && $status =~ /UP/) {

>Release-Note:
>Audit-Trail:
>Unformatted: