Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Apr 2011 08:53:22 -0400 (EDT)
From:      Rick Macklem <rmacklem@uoguelph.ca>
To:        Kostik Belousov <kostikbel@gmail.com>
Cc:        svn-src-head@freebsd.org, Rick Macklem <rmacklem@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r220906 - head/sys/fs/nfsclient
Message-ID:  <1922665091.396905.1303390402850.JavaMail.root@erie.cs.uoguelph.ca>
In-Reply-To: <20110421103300.GK48734@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
> 
> Is vnode lock held at this point ? If yes, I suggest to add
> ASSERT_VOP_{E,}LOCKED() assertion both to enforce the invariant, and
> to document the state to readers of the code.

Well, I thought it was always locked, but when I added the assertion
it failed for an I/O RPC done by the nfsiod. So, I've reverted it and
need to spend some time figuring out if I can lock the vnode safely
for the I/O operations done by the nfsiod.

Thanks for spotting this, rick



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1922665091.396905.1303390402850.JavaMail.root>