From owner-svn-src-head@FreeBSD.ORG  Thu Apr 21 12:53:24 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88C0B106564A;
	Thu, 21 Apr 2011 12:53:24 +0000 (UTC)
	(envelope-from rmacklem@uoguelph.ca)
Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca
	[131.104.91.44])
	by mx1.freebsd.org (Postfix) with ESMTP id 068868FC1C;
	Thu, 21 Apr 2011 12:53:23 +0000 (UTC)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: ApwEANgnsE2DaFvO/2dsb2JhbACEUKFviHCqTJB7gSmBWYF3fQSOKw
X-IronPort-AV: E=Sophos;i="4.64,251,1301889600"; d="scan'208";a="119088092"
Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca)
	([131.104.91.206])
	by esa-jnhn-pri.mail.uoguelph.ca with ESMTP; 21 Apr 2011 08:53:22 -0400
Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1])
	by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id DCE61B3F38;
	Thu, 21 Apr 2011 08:53:22 -0400 (EDT)
Date: Thu, 21 Apr 2011 08:53:22 -0400 (EDT)
From: Rick Macklem <rmacklem@uoguelph.ca>
To: Kostik Belousov <kostikbel@gmail.com>
Message-ID: <1922665091.396905.1303390402850.JavaMail.root@erie.cs.uoguelph.ca>
In-Reply-To: <20110421103300.GK48734@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.17.91.202]
X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE7 (Win)/6.0.10_GA_2692)
Cc: svn-src-head@freebsd.org, Rick Macklem <rmacklem@freebsd.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r220906 - head/sys/fs/nfsclient
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2011 12:53:24 -0000

> 
> Is vnode lock held at this point ? If yes, I suggest to add
> ASSERT_VOP_{E,}LOCKED() assertion both to enforce the invariant, and
> to document the state to readers of the code.

Well, I thought it was always locked, but when I added the assertion
it failed for an I/O RPC done by the nfsiod. So, I've reverted it and
need to spend some time figuring out if I can lock the vnode safely
for the I/O operations done by the nfsiod.

Thanks for spotting this, rick