From owner-svn-src-all@FreeBSD.ORG Sun Aug 18 19:53:17 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1FC22D84; Sun, 18 Aug 2013 19:53:17 +0000 (UTC) (envelope-from joel@freebsd.org) Received: from mail.vnode.se (mail.vnode.se [212.247.52.13]) by mx1.freebsd.org (Postfix) with ESMTP id CE7372978; Sun, 18 Aug 2013 19:53:16 +0000 (UTC) Received: from mail.vnode.se (localhost [127.0.0.1]) by mail.vnode.se (Postfix) with ESMTP id 04F91E3F07A; Sun, 18 Aug 2013 21:53:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at vnode.se Received: from mail.vnode.se ([127.0.0.1]) by mail.vnode.se (mail.vnode.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AbGr2TJuvLr6; Sun, 18 Aug 2013 21:53:06 +0200 (CEST) Received: from devbox.vnode.local (unknown [83.223.1.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.vnode.se (Postfix) with ESMTPSA id D7842E3F079; Sun, 18 Aug 2013 21:53:05 +0200 (CEST) Date: Sun, 18 Aug 2013 21:53:04 +0200 From: Joel Dahl To: Dimitry Andric Subject: Re: svn commit: r254273 - in head: . include lib lib/libc/iconv lib/libiconv_compat lib/libkiconv share/mk sys/sys tools/build/mk Message-ID: <20130818195304.GA81160@devbox.vnode.local> References: <201308130715.r7D7F1nu076335@svn.freebsd.org> <3887D7C7-D766-40DF-B154-D05768B86AA6@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3887D7C7-D766-40DF-B154-D05768B86AA6@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, FreeBSD Ports , Peter Wemm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Aug 2013 19:53:17 -0000 On Sun, Aug 18, 2013 at 12:34:30AM +0200, Dimitry Andric wrote: > On Aug 13, 2013, at 09:15, Peter Wemm wrote: > > Author: peter > > Date: Tue Aug 13 07:15:01 2013 > > New Revision: 254273 > > URL: http://svnweb.freebsd.org/changeset/base/254273 > > > > Log: > > The iconv in libc did two things - implement the standard APIs, the GNU > > extensions and also tried to be link time compatible with ports libiconv. > > This splits that functionality and enables the parts that shouldn't > > interfere with the port by default. > > > > WITH_ICONV (now on by default) - adds iconv.h, iconv_open(3) etc. > > WITH_LIBICONV_COMPAT (off by default) adds the libiconv_open etc API, linker > > symbols and even a stub libiconv.so.3 that are good enough to be able > > to 'pkg delete -f libiconv' on a running system and reasonably expect it > > to work. > > > > I have tortured many machines over the last few days to try and reduce > > the possibilities of foot-shooting as much as I can. I've successfully > > recompiled to enable and disable the libiconv_compat modes, ports that use > > libiconv alongside system iconv etc. If you don't enable the > > WITH_LIBICONV_COMPAT switch, they don't share symbol space. > > > > This is an extension of behavior on other system. iconv(3) is a standard > > libc interface and libiconv port expects to be able to run alongside it on > > systems that have it. > > Unfortunately I expect this will break many ports, when the libiconv > port is installed. A simple example is the following: It also breaks installworld when /usr/src and /usr/obj are NFS exported read-only. -- Joel