Date: Wed, 20 Jun 2018 14:55:38 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 229061] deskutils/gnome-screenshot: Update to 3.22.0 Message-ID: <bug-229061-6497-jbItKjw0CG@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-229061-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-229061-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229061 --- Comment #4 from Ting-Wei Lan <lantw44@gmail.com> --- Comment on attachment 194353 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D194353 patch-gnome-screenshot-3.22.0 >Index: deskutils/gnome-screenshot/Makefile >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >--- deskutils/gnome-screenshot/Makefile (revision 472678) >+++ deskutils/gnome-screenshot/Makefile (working copy) >@@ -2,7 +2,7 @@ > # $FreeBSD$ >=20 > PORTNAME=3D gnome-screenshot >-PORTVERSION=3D 3.18.0 >+PORTVERSION=3D 3.22.0 Is there any reason that you want to update it to 3.22.0 instead of the lat= est 3.26.0 release? > CATEGORIES=3D deskutils gnome > MASTER_SITES=3D GNOME > DIST_SUBDIR=3D gnome3 >@@ -10,17 +10,26 @@ > MAINTAINER=3D gnome@FreeBSD.org > COMMENT=3D GNOME 3 utility for making picutures of your screen >=20 >-LIB_DEPENDS=3D libcanberra-gtk3.so:audio/libcanberra-gtk3 >+LICENSE=3D GPLv2 >+LICENSE_FILE=3D ${WRKSRC}/COPYING >=20 >+LIB_DEPENDS=3D libcanberra-gtk3.so:audio/libcanberra-gtk3 \ >+ libcanberra.so:audio/libcanberra >+ OK, I found the same change is also committed to the FreeBSD GNOME developm= ent repository. > CONFLICTS=3D gnome-utils-2.[0-9]* > PORTSCOUT=3D limitw:1,even >=20 >-USES=3D gettext gmake gnome pathfix pkgconfig tar:xz >-USE_GNOME=3D gtk30 intlhack >+USES=3D gettext-tools gmake gnome localbase pathfix pkgconfig tar:xz >+USE_GNOME=3D cairo gdkpixbuf2 gtk30 intlhack >+USE_XORG=3D x11 xext > GNU_CONFIGURE=3D yes >-CPPFLAGS+=3D -I${LOCALBASE}/include >-LIBS+=3D -L${LOCALBASE}/lib >=20 > GLIB_SCHEMAS=3D org.gnome.gnome-screenshot.gschema.xml >=20 >+OPTIONS_DEFINE=3D NLS >+OPTIONS_SUB=3D yes >+ >+NLS_USES=3D gettext-runtime >+NLS_CONFIGURE_OFF=3D --disable-nls >+ > .include <bsd.port.mk> Adding NLS option looks fine, but I think many GNOME ports don't do it. Is there a use case other than saving disk space? >Index: deskutils/gnome-screenshot/distinfo >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >--- deskutils/gnome-screenshot/distinfo (revision 472678) >+++ deskutils/gnome-screenshot/distinfo (working copy) >@@ -1,2 +1,3 @@ >-SHA256 (gnome3/gnome-screenshot-3.18.0.tar.xz) =3D eba64dbf4acf0ab8222fec= 549d0a4f2dd7dbd51c255e7978dedf1f5c06a98841 >-SIZE (gnome3/gnome-screenshot-3.18.0.tar.xz) =3D 281752 >+TIMESTAMP =3D 1529110023 >+SHA256 (gnome3/gnome-screenshot-3.22.0.tar.xz) =3D 8a05f14b3c7c6cb42f9848= ad0332034c7fe5c34a69742910203588fd60b00230 >+SIZE (gnome3/gnome-screenshot-3.22.0.tar.xz) =3D 258888 >Index: deskutils/gnome-screenshot/files/patch-src_screenshot-utils.c >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >--- deskutils/gnome-screenshot/files/patch-src_screenshot-utils.c (nonexis= tent) >+++ deskutils/gnome-screenshot/files/patch-src_screenshot-utils.c (working= copy) >@@ -0,0 +1,20 @@ >+--- src/screenshot-utils.c.orig 2016-07-11 14:55:18 UTC >++++ src/screenshot-utils.c >+@@ -630,6 +630,9 @@ screenshot_get_pixbuf (GdkRectangle *rec >+ filename); >+ } >+=20 >++ if (!g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "GNOME")) >++ screenshot =3D screenshot_fallback_get_pixbuf(rectangle); Why is it needed? Does it mean the builtin screenshot function of GNOME She= ll is broken on your system? >++ else { >+ connection =3D g_application_get_dbus_connection (g_application_get_de= fault ()); >+ g_dbus_connection_call_sync (connection, >+ "org.gnome.Shell.Screenshot", >+@@ -659,6 +662,7 @@ screenshot_get_pixbuf (GdkRectangle *rec >+=20 >+ screenshot =3D screenshot_fallback_get_pixbuf (rectangle); >+ } >++ } >+=20 >+ g_free (path); >+ g_free (tmpname); > >Property changes on: deskutils/gnome-screenshot/files/patch-src_screenshot= -utils.c >___________________________________________________________________ >Added: fbsd:nokeywords >## -0,0 +1 ## >+yes >\ No newline at end of property >Added: svn:eol-style >## -0,0 +1 ## >+native >\ No newline at end of property >Added: svn:mime-type >## -0,0 +1 ## >+text/plain >\ No newline at end of property >Index: deskutils/gnome-screenshot/pkg-descr >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >--- deskutils/gnome-screenshot/pkg-descr (revision 472678) >+++ deskutils/gnome-screenshot/pkg-descr (working copy) >@@ -1 +1,4 @@ >-GNOME 3.0 utility for taking pictures of your screen. >+GNOME Screenshot is a small utility that takes a screenshot of the whole >+desktop; the currently focused window; or an area of the screen. >+ >+WWW: https://github.com/GNOME/gnome-screenshot This link is not correct. GNOME uses its own GitLab instance for developmen= t. GitHub is just a read-only mirror. I think you should put https://gitlab.gnome.org/GNOME/gnome-screenshot here. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229061-6497-jbItKjw0CG>