Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Apr 2018 09:17:09 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <royger@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86
Message-ID:  <201804061617.w36GH9sw003442@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201804061120.w36BK6s6074635@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> Author: royger
> Date: Fri Apr  6 11:20:06 2018
> New Revision: 332092
> URL: https://svnweb.freebsd.org/changeset/base/332092
> 
> Log:
>   remove GiB/MiB macros from param.h
>   
>   And instead define them in the files where they are used.

It would of been better to "revert" your prior change and
make a seperate new commit.  It is rarely desireable to combine
a revert of a change with anything.


>   Requested by: bde
> 
> Modified:
>   head/sys/amd64/amd64/mp_machdep.c
>   head/sys/sys/param.h
>   head/sys/x86/x86/mp_x86.c
> 
> Modified: head/sys/amd64/amd64/mp_machdep.c
...

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804061617.w36GH9sw003442>