From owner-svn-ports-head@FreeBSD.ORG Wed Jul 18 10:04:26 2012 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5B84D1065676 for ; Wed, 18 Jul 2012 10:04:26 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 016858FC15 for ; Wed, 18 Jul 2012 10:04:25 +0000 (UTC) Received: by obbun3 with SMTP id un3so2542337obb.13 for ; Wed, 18 Jul 2012 03:04:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=C24pMxbK9IxgBB7c9vMm3MQVsNToVMWn9x8D9MycQaw=; b=j/XMlBmeXuXS3ba8PC4KZLfgUdCRKWXo4omHm669+8FrhYjaYzU2QSdAOsDm8+x2s+ oKE6pBbNW6Xb7O3BMxjt9ZfP81ev2nqXuSDPeoMx3OdOT5jv2RCAK6RHVgwb56ML0S4P od8BVj6bVgCjiSQAJcf71nsmtuAYWA1/4UYDza6fAp/hBclVJuzQXwv5lX3Kysl/St9M P/ezcSdWgAhPWel8lIxWruSzMwDMFWMTyf51w98yf35s7qKPqzc5K0h7U0/om6ESI13D hPgexGYbu/8hmaypi98eP/UIK3T92ZS+B5ZsDefkcMBBrfJKPZd3Vx3pU95/UKElt+xi pifQ== Received: by 10.182.85.8 with SMTP id d8mr257410obz.70.1342605865251; Wed, 18 Jul 2012 03:04:25 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.182.36.225 with HTTP; Wed, 18 Jul 2012 03:04:04 -0700 (PDT) In-Reply-To: <50068063.1040701@dougbarton.us> References: <201207172057.q6HKvEJc094784@svn.freebsd.org> <5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org> <20120717230739.GA66332@ravenloft.kiev.ua> <5005F1E3.7080606@dougbarton.us> <20120717234412.GA69885@ravenloft.kiev.ua> <5005FDBD.5000407@dougbarton.us> <20120718001944.GA71608@ravenloft.kiev.ua> <500676B1.30403@dougbarton.us> <20120718091509.GA53570@FreeBSD.org> <50068063.1040701@dougbarton.us> From: Sunpoet Po-Chuan Hsieh Date: Wed, 18 Jul 2012 18:04:04 +0800 X-Google-Sender-Auth: PpXmG0YOw0AJ7_FxyGGwN962r6M Message-ID: To: Doug Barton Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQll+01WA81/nGiJcMHN5yWsnONDdZ/1iL+5Yj6xlPTCrxlCflCkgVumITjww44obILFOGmF Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, Alex Kozlov , ports-committers@freebsd.org, Niclas Zeising Subject: Re: svn commit: r301039 - head/archivers/zlib X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2012 10:04:26 -0000 On Wed, Jul 18, 2012 at 5:22 PM, Doug Barton wrote: > On 07/18/2012 02:15, Alexey Dokuchaev wrote: >> On Wed, Jul 18, 2012 at 01:41:21AM -0700, Doug Barton wrote: >>> On 07/17/2012 17:19, Alex Kozlov wrote: >>>> Those two lines above are not only list of distinfo files with absent >>>> EOL at the last line, but also an example of real parser which broken >>>> by such distinfo. >>> >>> So again, what I'm asking for are the *details* of what was broken, and >>> how. >>> >>> And FWIW, since that was my *first* question, you could have started off >>> with this answer instead of engaging in pointless theoretical discussion. >> >> Come on, guys, let's just fix the damn bug and be done with it. I totally >> understand how minor this issue is, yet how annoying in the same time (if we >> forget about very strict parsers). > > So you want us to do work for you, but you don't want to explain why? > > Meanwhile, since we don't know how the problem comes into being in the > first place, wouldn't it be better for you to share the problem you're > seeing so that we can help you find a more robust fix? > > You're taking sort of an absurd approach to what should have been a > really simple issue. > > Doug > > -- > If you're never wrong, you're not trying hard enough > > Hi Doug, AFAIK, if you download patch via patch file links [1], you'll get a patch file without newline character at the end of file. I guess most missing newline characters are caused by this problem. [1] e.g. http://www.freebsd.org/cgi/query-pr.cgi?pr=169349&getpatch=1