From owner-svn-src-head@freebsd.org Wed Jun 8 20:54:57 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA630B6FB5A; Wed, 8 Jun 2016 20:54:57 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 783FB139B; Wed, 8 Jun 2016 20:54:57 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u58Ksu6r009440; Wed, 8 Jun 2016 20:54:56 GMT (envelope-from ed@FreeBSD.org) Received: (from ed@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u58KsuA8009439; Wed, 8 Jun 2016 20:54:56 GMT (envelope-from ed@FreeBSD.org) Message-Id: <201606082054.u58KsuA8009439@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ed set sender to ed@FreeBSD.org using -f From: Ed Schouten Date: Wed, 8 Jun 2016 20:54:56 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r301696 - head/contrib/atf X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2016 20:54:57 -0000 Author: ed Date: Wed Jun 8 20:54:56 2016 New Revision: 301696 URL: https://svnweb.freebsd.org/changeset/base/301696 Log: Don't let ATF call basename() and dirname() in a non-standard way. POSIX basename() and dirname() are allowed to overwrite the input buffer. The advantage of implementing it that way is that the functions can be thread-safe, as they don't store the result in a global buffer. It looks like ATF wants to call basename() and dirname() in the non-standard way where the argument is of type "const char *". This change disables the calls to basename() and dirname(), which only seems to affect the formatting of some rare debug/error messages. Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D6627 Modified: head/contrib/atf/config.h Modified: head/contrib/atf/config.h ============================================================================== --- head/contrib/atf/config.h Wed Jun 8 20:47:25 2016 (r301695) +++ head/contrib/atf/config.h Wed Jun 8 20:54:56 2016 (r301696) @@ -2,10 +2,10 @@ /* config.h.in. Generated from configure.ac by autoheader. */ /* Define to 1 if basename takes a constant pointer */ -#define HAVE_CONST_BASENAME 1 +/* #undef HAVE_CONST_BASENAME */ /* Define to 1 if dirname takes a constant pointer */ -#define HAVE_CONST_DIRNAME 1 +/* #undef HAVE_CONST_DIRNAME */ /* Define to 1 if you have the header file. */ #define HAVE_DLFCN_H 1