Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 12 Jan 2021 16:51:01 GMT
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 79818c801026 - stable/12 - MFC aca12148b113: Improve error message printing in krping. Don't print completion queue flush as an error.
Message-ID:  <202101121651.10CGp14X095653@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by hselasky:

URL: https://cgit.FreeBSD.org/src/commit/?id=79818c80102617558796df7b1cd9b7087cf39830

commit 79818c80102617558796df7b1cd9b7087cf39830
Author:     Hans Petter Selasky <hps@selasky.org>
AuthorDate: 2020-12-09 12:59:01 +0000
Commit:     Hans Petter Selasky <hselasky@FreeBSD.org>
CommitDate: 2021-01-12 16:45:45 +0000

    MFC aca12148b113:
    Improve error message printing in krping.
    Don't print completion queue flush as an error.
    
    Sponsored by:   Mellanox Technologies // NVIDIA Networking
---
 sys/contrib/rdma/krping/krping.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/sys/contrib/rdma/krping/krping.c b/sys/contrib/rdma/krping/krping.c
index c734da36247f..e9a379984dec 100644
--- a/sys/contrib/rdma/krping/krping.c
+++ b/sys/contrib/rdma/krping/krping.c
@@ -362,10 +362,6 @@ static void krping_cq_event_handler(struct ib_cq *cq, void *ctx)
 	int ret;
 
 	BUG_ON(cb->cq != cq);
-	if (cb->state == ERROR) {
-		printk(KERN_ERR PFX "cq completion in ERROR state\n");
-		return;
-	}
 	if (cb->frtest) {
 		printk(KERN_ERR PFX "cq completion event in frtest!\n");
 		return;
@@ -384,7 +380,10 @@ static void krping_cq_event_handler(struct ib_cq *cq, void *ctx)
 				goto error;
 			}
 		}
-
+		if (cb->state == ERROR) {
+			printk(KERN_ERR PFX "cq completion in ERROR state\n");
+			return;
+		}
 		switch (wc.opcode) {
 		case IB_WC_SEND:
 			DEBUG_LOG("send completion\n");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202101121651.10CGp14X095653>