Date: Thu, 23 Apr 2015 13:26:19 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 195313] [maintainer] net/hanstunnel Message-ID: <bug-195313-13-EK1Yh0Ow7P@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-195313-13@https.bugs.freebsd.org/bugzilla/> References: <bug-195313-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195313 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-ports-bugs@FreeBSD. |jbeich@FreeBSD.org |org | CC| |marino@FreeBSD.org Status|Open |In Progress Attachment #155912| |maintainer-approval?(vsityz Flags| |@gmail.com), | |maintainer-approval?(marino | |@FreeBSD.org) --- Comment #5 from Jan Beich <jbeich@FreeBSD.org> --- Created attachment 155912 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155912&action=edit update and refactor (requesting marino@ review if only for DragonFly bits) How about throwing out all that legacy cruft? - No need to revert MASTER_SITES to old format with _SUBDIR variable - No need to hardcode LOCALBASE in PLIST_FILES while installing under PREFIX - No need to remove #ifdef/#ifndef LINUX because no BSD system defines it - No need to replace $(FOO) with ${FOO} as fmake and bmake accept both - No need for CLANG option for the port builds fine with gcc42[1] - No need to patch Makefile if you only need to override a few variables - No need to ${CAT} ${PKGMESSAGE} as this is deprecated by staging While here maybe also - Add FPL to LICENSEs - Fix build on DragonFly [2] - Respect CFLAGS/LDFLAGS again after update - Rename patches according to |make makepatch| Tested on 8.4R amd64, 9.3R i386, 10.1R amd64, 10.1R i386, 11.0C i386. [1] The ports framework allows interested users to change compiler by setting CC, CXX, CPP variables in make.conf. Trying to set CC=clang is going to make DragonFly unhappy if the port works fine otherwise. [2] http://muscles.dragonflybsd.org/bulk/latest-per-pkg/hans/0.4.1_1/bleeding-edge-potential.log -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-195313-13-EK1Yh0Ow7P>