From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 23 13:26:19 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E12931CB for ; Thu, 23 Apr 2015 13:26:19 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B0F961CCB for ; Thu, 23 Apr 2015 13:26:19 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t3NDQJeQ054413 for ; Thu, 23 Apr 2015 13:26:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 195313] [maintainer] net/hanstunnel Date: Thu, 23 Apr 2015 13:26:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jbeich@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to cc bug_status flagtypes.name attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2015 13:26:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195313 Jan Beich changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-ports-bugs@FreeBSD. |jbeich@FreeBSD.org |org | CC| |marino@FreeBSD.org Status|Open |In Progress Attachment #155912| |maintainer-approval?(vsityz Flags| |@gmail.com), | |maintainer-approval?(marino | |@FreeBSD.org) --- Comment #5 from Jan Beich --- Created attachment 155912 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155912&action=edit update and refactor (requesting marino@ review if only for DragonFly bits) How about throwing out all that legacy cruft? - No need to revert MASTER_SITES to old format with _SUBDIR variable - No need to hardcode LOCALBASE in PLIST_FILES while installing under PREFIX - No need to remove #ifdef/#ifndef LINUX because no BSD system defines it - No need to replace $(FOO) with ${FOO} as fmake and bmake accept both - No need for CLANG option for the port builds fine with gcc42[1] - No need to patch Makefile if you only need to override a few variables - No need to ${CAT} ${PKGMESSAGE} as this is deprecated by staging While here maybe also - Add FPL to LICENSEs - Fix build on DragonFly [2] - Respect CFLAGS/LDFLAGS again after update - Rename patches according to |make makepatch| Tested on 8.4R amd64, 9.3R i386, 10.1R amd64, 10.1R i386, 11.0C i386. [1] The ports framework allows interested users to change compiler by setting CC, CXX, CPP variables in make.conf. Trying to set CC=clang is going to make DragonFly unhappy if the port works fine otherwise. [2] http://muscles.dragonflybsd.org/bulk/latest-per-pkg/hans/0.4.1_1/bleeding-edge-potential.log -- You are receiving this mail because: You are the assignee for the bug.