From owner-freebsd-emulation@FreeBSD.ORG Mon Jun 2 07:54:02 2008 Return-Path: Delivered-To: freebsd-emulation@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 249741065677 for ; Mon, 2 Jun 2008 07:54:02 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id B4A6B8FC14 for ; Mon, 2 Jun 2008 07:54:01 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 5749267EA69; Mon, 2 Jun 2008 09:53:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YGzCFFHT4FLS; Mon, 2 Jun 2008 09:53:15 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id AE38A67E7D8; Mon, 2 Jun 2008 09:53:15 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.2/8.14.2/Submit) id m527rFWa067688; Mon, 2 Jun 2008 09:53:15 +0200 (CEST) (envelope-from rdivacky) Date: Mon, 2 Jun 2008 09:53:15 +0200 From: Roman Divacky To: Ed Schouten Message-ID: <20080602075315.GB67510@freebsd.org> References: <20080602073152.GO64397@hoeg.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <20080602073152.GO64397@hoeg.nl> User-Agent: Mutt/1.4.2.3i Cc: freebsd-emulation@FreeBSD.org, philip@FreeBSD.org Subject: Re: Linux major/minor conversion not entirely correct X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2008 07:54:02 -0000 --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 02, 2008 at 09:31:52AM +0200, Ed Schouten wrote: > Hello everyone, >=20 > The last couple of months I've been working on redesigning FreeBSD's TTY > layer. This is all going quite good. Too good, actually. >=20 > Last week I've been toying around with getting sshd working inside a > Linux jail, which seems to work quite nicely right now. I've made some > changes to our Linux compat layer that could already get (partially) > merged back to SVN. >=20 > The Linux compat layer generates fake major/minor numbers for certain > devices, because Linux still depends on that information a lot (yuck). > I've discovered that our Linux compat layer returns the same major/minor > pair for all nodes in /dev/pts, but doesn't do this consistently either. > We'd better push the conversion down into linux_driver_get_major_minor(), > to make sure the numbers always get converted. We should also make sure > we hand out unique numbers. >=20 > The patch also contains a change I made to support the new DTYPE_PTS > (pseudo-terminal master device). This part of the diff should be > ignored. I've just added it for completeness. >=20 > Does anyone mind if I commit this patch soonish? I dont see a problem with it... go commit that. thnx! --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkhDpusACgkQLVEj6D3CBExamwCfZrps5Gv8JBvg8KjvsB/GjrRb gv4AniCY4xC1c+BLqq91Lby99FL/mBmU =K5nh -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--