From owner-svn-src-all@freebsd.org Fri Feb 19 01:28:56 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE3AAAAD890 for ; Fri, 19 Feb 2016 01:28:55 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C0811D1D for ; Fri, 19 Feb 2016 01:28:55 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: by mail-wm0-x22c.google.com with SMTP id g62so49310043wme.0 for ; Thu, 18 Feb 2016 17:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sippysoft-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=aj6UyJfoIGffNbaRzAomS+6iNjty+1ydwOwiCdK2b3U=; b=pdiG4ee/rlTR6modco/PNcpG8k/mXtBNnB/w4aRpAXvcP0npMmLUviTR0sTmygzd4N aDpyTlXfx1SLZR/rRKMKWTzxB1LVA9xPcjZxuiYjDIrqtiqPk64C3BFwFut5nDcNvCZI LAxh8Siy0xGCzlZAhaE4ADjIb3+xvKf/qHpiVSGhSRXUnxXDIUhsYBYG4XWKsENheFZ/ ZaH3aAJv3jsgxlnOk4A2DD8vD4Y0tw6GozuM5BnomlFWdae54aGA+f9i4aIxyI7vDaJW PiGy6YIn2bN/rCauFxRJfiACewlMJidKkl1xnG/SMrT5tXFnXbUOXWb61/XJqez5AdI6 9LBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=aj6UyJfoIGffNbaRzAomS+6iNjty+1ydwOwiCdK2b3U=; b=bp8VI+MDe9iVguso7L/P5ab65Y34a25ECr8RtKnHxuJfbdh2f7xU1v0A8JoS/BWXqJ ETYWGRgX9H7VQbMFaczOE8G/VYfEr2RhkBLb18HEIbB0oiZUh72yyAA1GGlyDzEuGWXO tBVzOmKzpBs2yYRWef24jSQ2oZtbAQQBuH8m0gnea3bkltKFOr45vE8aQ3blm286DDBe G8n8wieciuo9E5FqsE/Y2j7Z1NRhoD1xHs7FZqqVa72vH/VwKaUnTEZGXqZOdJLMESaN N+74mCLt6deeL7FLZ0I9s8+9JJlfW0ePtE+CrsLMJAVz56UhJh+175a/TD/7Bqea2R7i CPUg== X-Gm-Message-State: AG10YOTOkE9E7dWz2ENg+EYpSQtumAhCqWhl6/cV6MKunmMxTb+d8pZv9UA9Z4abql7RGpEsH5NCdCEmhizgYEmL MIME-Version: 1.0 X-Received: by 10.28.228.214 with SMTP id b205mr6614953wmh.94.1455845333955; Thu, 18 Feb 2016 17:28:53 -0800 (PST) Received: by 10.27.218.12 with HTTP; Thu, 18 Feb 2016 17:28:53 -0800 (PST) In-Reply-To: <56C66415.7040407@FreeBSD.org> References: <56C66415.7040407@FreeBSD.org> Date: Thu, 18 Feb 2016 17:28:53 -0800 Message-ID: Subject: Re: svn commit: r229537 - in head/sys: conf geom/uncompress modules/geom/geom_uncompress From: Maxim Sobolev To: Bryan Drewery Cc: ray@freebsd.org, Adrian Chadd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 01:28:56 -0000 Sigh, I don't now how it managed to sleep through usually tight FreeBSD peer-review process. It would be interesting to hear some comments from @ray and @adrian, perhaps there were some reasons for it being done this way, although I cannot see any in a hindsight. I am just in the middle of rather substantial overhaul of both kernel and userland part here: https://reviews.freebsd.org/D5333 And once that committed it will take them apart again. I've also spend quite lot of time testing my change set, which would with very little effort have covered both formats had I started with unified code base. :( I also plan on making further improvement into kernel module, as it is right now both g_uzip and g_uncompress basically piggyback single "g_up" thread, so you cannot use multiple cores even for different instances, let alone one instance being accessed by multiple readers. And it also can delay other unrelated I/O requests by maxing out CPU time slice available for the g_up. On Thu, Feb 18, 2016 at 4:38 PM, Bryan Drewery wrote: > On 2/18/2016 3:57 PM, Maxim Sobolev wrote: > > Aleksandr, Adrian, > > > > I know it's 3 years later, but I really don't know why it's been done > > this way. Take a GEOM module and associated usr.bin utility, copy it > > verbatim add few lines of code and re-add that as a new module seems > > like just laziness and attempt to avoid doing extra work on making > > unified code. The same goes for the mkulzma, which is almost 1:1 copy of > > the mkuzip. Now people are merging back and forth and I've just spent > > few days testing some rather major rework of geom_uzip / mkuzip code not > > even realizing that there is its evil twin in the tree. :( > > r283104 is an example of one of these problems. It was a catch-up of > uzip's r268986 done almost a year before. I did comparisons before using > uzip last summer and ran across that one. > > > > > https://reviews.freebsd.org/D5333 > > > > I suggest functionality from both geom_uncompress / mkulzma are folded > > now back into geom_uzip / mkuzip and geom_uncompress / mkulzma are nuked > > afterwards. > > > > Thanks! > > > > > > > > Author: ray > > Date: Wed Jan 4 23:39:11 2012 > > New Revision: 229537 > > URL: http://svn.freebsd.org/changeset/base/229537 > > Log: > > GEOM_UNCOMPRESS module, can be used with uzip images and with new > > ulzma images. > > Approved by: adrian (mentor) > > Added: > > head/sys/geom/uncompress/ > > head/sys/geom/uncompress/g_uncompress.c (contents, props changed) > > head/sys/modules/geom/geom_uncompress/ > > head/sys/modules/geom/geom_uncompress/Makefile (contents, props > changed) > > Modified: > > head/sys/conf/files > > head/sys/conf/options > > > > > > > -- > Regards, > Bryan Drewery > > -- Maksym Sobolyev Sippy Software, Inc. Internet Telephony (VoIP) Experts Tel (Canada): +1-778-783-0474 Tel (Toll-Free): +1-855-747-7779 Fax: +1-866-857-6942 Web: http://www.sippysoft.com MSN: sales@sippysoft.com Skype: SippySoft