Date: Wed, 31 Jul 2013 07:57:57 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r324014 - in head/graphics/volpack: . files Message-ID: <20130731075757.GA30753@FreeBSD.org> In-Reply-To: <51F8C249.7070902@FreeBSD.org> References: <201307310743.r6V7hrA1063035@svn.freebsd.org> <51F8C249.7070902@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 31, 2013 at 09:52:41AM +0200, Guido Falsi wrote: > On 07/31/13 09:43, Alexey Dokuchaev wrote: > >Author: danfe > >Date: Wed Jul 31 07:43:53 2013 > >New Revision: 324014 > >URL: http://svnweb.freebsd.org/changeset/ports/324014 > > > >Log: > > Try to properly fix parallel builds instead of marking port as -jX unsafe. > > Thanks :) Would have never thought of this solution myself :) You're welcome. Actually once you've seen enough of broken makefiles, these patterns catch eye quickly. For example, shell "for" loops in targets is a good indication of potential fuckup. Generally, the more imperative the Makefile gets (while it would be declarative as possible), the more chances something will break at -jX. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130731075757.GA30753>