Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 03 Nov 2000 20:54:56 +0900
From:      Makoto MATSUSHITA <matusita@jp.FreeBSD.org>
To:        stable@freebsd.org
Subject:   src/sys/modules/linux of RELENG_4 is not 'make -j' safe
Message-ID:  <20001103205456L.matusita@jp.FreeBSD.org>

next in thread | raw e-mail | index | archive | help

I've found that current src/sys/modules/linux for RELENG_4 is not
'make -j' safe. It maybe causes a problem if you want to make a
module. This problem comes from recent MI/MD changes to linux module.

Here is a sample session:

% make obj
/usr/obj/usr/src/sys/modules/linux created for /usr/src/sys/modules/linux
% make -j 2
@ -> /usr/src/sys
machine -> /usr/src/sys/i386/include
echo "#define COMPAT_43 1" > opt_compat.h
touch opt_linux.h
touch opt_vmpage.h
gzip -cn /usr/src/sys/modules/linux/linux.8 > linux.8.gz
perl @/kern/vnode_if.pl -h @/kern/vnode_if.src
sh @/kern/makesyscalls.sh @/i386/linux/syscalls.master @/i386/linux/syscalls.conf
sh @/kern/makesyscalls.sh @/i386/linux/syscalls.master @/i386/linux/syscalls.conf
sed -e 's|i386/linux/linux_proto\.h|linux_proto.h|g'  linux_sysent.c > linux_sysent.c.fixup
mv -f linux_sysent.c.fixup linux_sysent.c
sed -e 's|i386/linux/linux_proto\.h|linux_proto.h|g'  linux_sysent.c > linux_sysent.c.fixup
mv -f linux_sysent.c.fixup linux_sysent.c
(.... deleted ...)
cc -O -pipe  -D_KERNEL -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -fformat-extensions -ansi -DKLD_MODULE -nostdinc -I- -I. -I@ -I@/../include  -mpreferred-stack-boundary=2 -c linux_sysent.c
sh @/kern/genassym.sh linux_genassym.o > linux_assym.h
linux_sysent.c:21: warning: cast discards qualifiers from pointer target type
linux_sysent.c:229: redefinition of `linux_sysent'
linux_sysent.c:19: `linux_sysent' previously defined here
linux_sysent.c:231: warning: cast discards qualifiers from pointer target type
*** Error code 1
1 error


This is because linux_sysent.c is broken:

% ls -l /usr/obj/usr/src/sys/modules/linux/linux_sysent.c
-rw-r--r--  1 root  wheel  29487 Nov  3 20:48 /usr/obj/usr/src/sys/modules/linux/linux_sysent.c
% grep linux_sysent /usr/obj/usr/src/sys/modules/linux/linux_sysent.c
struct sysent linux_sysent[] = {
struct sysent linux_sysent[] = {

It seems that this file contains two linux_sysent[] definition.

-- -
Makoto `MAR' MATSUSHITA


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001103205456L.matusita>