From owner-cvs-all  Wed Nov  6  8: 8:27 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 952F537B401; Wed,  6 Nov 2002 08:08:26 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 51BE043E75; Wed,  6 Nov 2002 08:08:25 -0800 (PST)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id gA6G8NB6002605;
	Wed, 6 Nov 2002 17:08:23 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Hidetoshi Shimokawa <simokawa@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/nge if_nge.c if_ngereg.h 
In-Reply-To: Your message of "Wed, 06 Nov 2002 07:50:32 PST."
             <200211061550.gA6FoWQj062987@repoman.freebsd.org> 
Date: Wed, 06 Nov 2002 17:08:23 +0100
Message-ID: <2604.1036598903@critter.freebsd.dk>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

In message <200211061550.gA6FoWQj062987@repoman.freebsd.org>, Hidetoshi Shimoka
wa writes:
>simokawa    2002/11/06 07:50:32 PST
>
>  Modified files:
>    sys/dev/nge          if_nge.c if_ngereg.h 
>  Log:
>  Add support for DEVICE_POLLING.
>  
>  PR: kern/44772
>  Submitted by: Takashi Oono <takashi@yha.att.ne.jp>
>  MFC after: 1 week
>  
>  Revision  Changes    Path
>  1.36      +76 -0     src/sys/dev/nge/if_nge.c
>  1.8       +3 -0      src/sys/dev/nge/if_ngereg.h

Hang on for a second:

This chip supports interrupt pacing so I would like to see
some documentation for an improvement from DEVICE_POLLING over
tuning the interrupt pacing in the chip, before we even think
about MFC, much less let this commit stay in the tree.

What tests have been run ?  
What are the numbers ?  (and please, include a standard deviation!)

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message