From owner-cvs-all@FreeBSD.ORG  Wed Apr  2 10:18:35 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E56DA37B405
	for <cvs-all@FreeBSD.org>; Wed,  2 Apr 2003 10:18:35 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 2B1FE43FB1
	for <cvs-all@FreeBSD.org>; Wed,  2 Apr 2003 10:18:32 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 11960 invoked by uid 1000); 2 Apr 2003 18:18:32 -0000
Date: Wed, 2 Apr 2003 10:18:32 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: SUZUKI Shinsuke <suz@FreeBSD.org>
In-Reply-To: <20030402113558.1A93537B417@hub.freebsd.org>
Message-ID: <Pine.BSF.4.21.0304021017260.11936-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/rtadvd config.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Apr 2003 18:18:36 -0000

On Wed, 2 Apr 2003, SUZUKI Shinsuke wrote:
>   Modified files:
>     usr.sbin/rtadvd      config.c 
>   Log:
>   fixed invalid pointer reference
>   
>   Obtained from: KAME
>   
>   Revision  Changes    Path
>   1.13      +1 -0      src/usr.sbin/rtadvd/config.c
> 
> 
> Index: src/usr.sbin/rtadvd/config.c
> diff -u src/usr.sbin/rtadvd/config.c:1.12 src/usr.sbin/rtadvd/config.c:1.13
> --- src/usr.sbin/rtadvd/config.c:1.12	Mon Dec 30 13:18:15 2002
> +++ src/usr.sbin/rtadvd/config.c	Wed Apr  2 03:35:51 2003
> @@ -1,4 +1,4 @@
> -/*	$FreeBSD: /repoman/r/ncvs/src/usr.sbin/rtadvd/config.c,v 1.12 2002/12/30 21:18:15 schweikh Exp $	*/
> +/*	$FreeBSD: /repoman/r/ncvs/src/usr.sbin/rtadvd/config.c,v 1.13 2003/04/02 11:35:51 suz Exp $	*/
>  /*	$KAME: config.c,v 1.37 2001/05/25 07:34:00 itojun Exp $	*/
>  
>  /*
> @@ -630,6 +630,7 @@
>  
>  		/* link into chain */
>  		insque(pp, &rai->prefix);
> +		pp->rainfo == rai;
>  
>  		/* counter increment */
>  		rai->pfxs++;

I think you want assignment, not equivalence test, especially since you
deref the pointer immediately afterwards.

-Nate