From owner-freebsd-acpi@FreeBSD.ORG Sat Feb 17 17:22:29 2007 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AEC2D16A409 for ; Sat, 17 Feb 2007 17:22:29 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 7A27413C4AC for ; Sat, 17 Feb 2007 17:22:29 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 71920 invoked from network); 17 Feb 2007 17:22:34 -0000 Received: from ppp-71-139-18-69.dsl.snfc21.pacbell.net (HELO ?10.0.5.59?) (nate-mail@71.139.18.69) by root.org with ESMTPA; 17 Feb 2007 17:22:34 -0000 Message-ID: <45D739C7.8090505@root.org> Date: Sat, 17 Feb 2007 09:22:15 -0800 From: Nate Lawson User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: Matteo Riondato References: <20070217140940.GB1040@krapfengeist.homenet.telecomitalia.it> In-Reply-To: <20070217140940.GB1040@krapfengeist.homenet.telecomitalia.it> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: bruno@freebsd.org, freebsd-acpi@freebsd.org Subject: Re: RFC: powerd patch to review related to bin/104689 X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Feb 2007 17:22:29 -0000 Matteo Riondato wrote: > All, > while digging in the PR database, I found bin/104689 and decided to > implement the idea in it. > > Basically, I added support in powerd(8) to specify a maximum and a > minimum frequencies for adaptive mode. That is, powerd will only > switch between frequencies between the specified bounds instead of > switching through all available frequencies. > > I think the idea is nice and I hope to have implemented it in the > right way, but I'd like your review before committing it. > > Patch is attached, or can be found at > http://people.freebsd.org/~matteo/powerd-minmaxfreq.patch > > (leave me in the reply list, since I'm not subscribed to > freebsd-acpi@) > > Thanks in advance > Best regards I appreciate your work on this. However, I'd prefer not to keep adding more user-visible command line flags that we'll have to support for backwards compat in the future. The current approach in powerd is a rough heuristic and with a little bit of work on good predictive algorithms (see Summer of Code description on wiki), we won't need to provide such specific tweaks. If we are going to provide this kind of configurability, it should be in a config file, not command line. I'd like to see a power policy config file that gives various profiles and events that cause a switch to each policy. Min/max would make sense there. Again, I appreciate your work but don't want to continue down the current path of powerd. It needs to be a real power management utility and have that flexibility. -- Nate