From owner-freebsd-multimedia  Thu Aug 14 01:11:36 1997
Return-Path: <owner-freebsd-multimedia>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id BAA04535
          for multimedia-outgoing; Thu, 14 Aug 1997 01:11:36 -0700 (PDT)
Received: from Octopussy.MI.Uni-Koeln.DE (Octopussy.MI.Uni-Koeln.DE [134.95.166.20])
          by hub.freebsd.org (8.8.5/8.8.5) with SMTP id BAA04517;
          Thu, 14 Aug 1997 01:11:31 -0700 (PDT)
Received: from x14.mi.uni-koeln.de ([134.95.219.124]) by Octopussy.MI.Uni-Koeln.DE with SMTP id AA12402
  (5.67b/IDA-1.5); Thu, 14 Aug 1997 10:11:25 +0200
Received: (from se@localhost) by x14.mi.uni-koeln.de (8.8.6/8.6.9) id KAA00877; Thu, 14 Aug 1997 10:10:56 +0200 (CEST)
X-Face: "<d]#=8pzx);RzeqSKI86OVa7=!0/(uRa.+B.9Z9\eNUn@UG?!`y7yt2dFNn%k4'.}](uE%
 yCO)$e&Y1%3EO~ifu6Q-#YUM&JZ't,}JkPnAz,8Dj33u%@GBi%[Y#LHz$]h7a<p4)-jKI7~sKjlP-^
 EvA[G;]v&0]W!EL%shs,{7x0|oqN4YVIs5,NI#,V{9"WF):5&RkOhyj*#-IAG}Tnu;YCF,d
Message-Id: <19970814101056.02120@mi.uni-koeln.de>
Date: Thu, 14 Aug 1997 10:10:56 +0200
From: Stefan Esser <se@FreeBSD.ORG>
To: Amancio Hasty <hasty@rah.star-gate.com>
Cc: Kenneth Merry <ken@plutotech.com>, multimedia@FreeBSD.ORG,
        freebsd-current@FreeBSD.ORG
Subject: Re: YES!, bktr now works 8)
References: <199708140525.XAA08949@pluto.plutotech.com> <199708140532.WAA00445@rah.star-gate.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.74
In-Reply-To: <199708140532.WAA00445@rah.star-gate.com>; from Amancio Hasty on Wed, Aug 13, 1997 at 10:32:04PM -0700
Sender: owner-freebsd-multimedia@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Aug 13, Amancio Hasty <hasty@rah.star-gate.com> wrote:
> > > 	fun = pci_conf_read(tag, PCI_COMMAND_STATUS_REG);
> > > 	pci_conf_write(tag, PCI_COMMAND_STATUS_REG, fun | 4); 
> > >  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ add this ^^^^^^^^^^^^^^^^^^^

Well, I'm not sure about the name, but a function that
enables or disables bits in the PCI command register 
might be a good idea.

How about:

	enables = pci_enable(PCI_MEM|PCI_PORT|PCI_DMA);
	enables = pci_disable(PCI_MEM|PCI_PORT|PCI_DMA);

where the result is in fact the low order three bits 
from the command register after trying to set them
according to the parameter ?

Regards, STefan