Date: Fri, 21 Sep 2001 15:06:22 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern sys_generic.c Message-ID: <200109212206.f8LM6MF13902@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
jhb 2001/09/21 15:06:22 PDT
Modified files:
sys/kern sys_generic.c
Log:
The P_SELECT flag was moved from p->p_flag to td->td_flags, but p_flag
was locked by the proc lock and td_flags is locked by the sched_lock.
The places that read, set, and cleared TDF_SELECT weren't updated, so they
read and modified td_flags w/o holding the sched_lock, meaning that they
could corrupt the per-thread flags field. As an immediate band-aid,
grab sched_lock while reading and manipulating td_flags in relation to
TDF_SELECT. This will probably be cleaned up some later on.
Revision Changes Path
1.82 +21 -3 src/sys/kern/sys_generic.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200109212206.f8LM6MF13902>