From owner-freebsd-ports@freebsd.org Thu Dec 19 10:04:53 2019 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6BB491DBC94 for ; Thu, 19 Dec 2019 10:04:53 +0000 (UTC) (envelope-from dave@661.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 47dnYK0JnZz4VRv for ; Thu, 19 Dec 2019 10:04:53 +0000 (UTC) (envelope-from dave@661.org) Received: by mailman.nyi.freebsd.org (Postfix) id 08CAF1DBC93; Thu, 19 Dec 2019 10:04:53 +0000 (UTC) Delivered-To: ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 077BE1DBC92 for ; Thu, 19 Dec 2019 10:04:53 +0000 (UTC) (envelope-from dave@661.org) Received: from hermes.661.org (hermes.661.org [192.81.131.210]) by mx1.freebsd.org (Postfix) with ESMTP id 47dnYH5ZYLz4VRs for ; Thu, 19 Dec 2019 10:04:51 +0000 (UTC) (envelope-from dave@661.org) Received: by hermes.661.org (Postfix, from userid 1000) id 67FEA1E42F; Thu, 19 Dec 2019 10:04:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hermes.661.org (Postfix) with ESMTP id 65A861E1C1; Thu, 19 Dec 2019 10:04:50 +0000 (UTC) Date: Thu, 19 Dec 2019 10:04:50 +0000 (UTC) From: David Griffith To: Marcin Cieslak cc: ports@FreeBSD.org Subject: Re: Frotz upgrade to 2.50 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 47dnYH5ZYLz4VRs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of dave@661.org has no SPF policy when checking 192.81.131.210) smtp.mailfrom=dave@661.org X-Spamd-Result: default: False [-1.01 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.969,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.83)[-0.829,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[661.org]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:63949, ipnet:192.81.131.0/24, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-0.21)[asn: 63949(-1.00), country: US(-0.05)] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Dec 2019 10:04:53 -0000 My reply is at the bottom. Please put your reply there too. On Thu, 19 Dec 2019, Marcin Cieslak wrote: > On Thu, 19 Dec 2019, David Griffith wrote: > >> >> My reply is at the bottom. Please put your reply there too. >> On Wed, 18 Dec 2019, Marcin Cieslak wrote: >>> On Mon, 16 Dec 2019, David Griffith wrote: >>> >>>> >>>> I released version 2.50 of Frotz last month. Would someone please update >>>> ports to install this version? >>> >>> I have never used that software but I gave it a try and: >>> >>> * moved it to Gitlab >>> * applied fix for a https://gitlab.com/DavidGriffith/frotz/issues/180 >>> * I think we do not need to generate soundcard.h manually anymore? >>> >>> Now I am getting: >>> >>> ===> Building for frotz-2.50 >>> gmake[2]: Entering directory >>> '/usr/home/saper/sw/FreeBSD/ports/games/frotz/work/frotz-9867a1f14da1e9c0707492d2ac74d1e8ffdd3a64-9867a1f14da1e9c0707492d2ac74d1e8ffdd3a64' >>> ** Generating src/common/defs.h >>> ** Generating src/common/git_hash.h >>> ** ERROR UTF-8 support only works with ncursesw! >>> exit 2 >>> gmake[2]: *** [Makefile:391: src/curses/ux_defines.h] Error 2 >>> >>> but then second "make" works just fine... >> >> The OSS interface is deprecated for now. There's no need to go hunting >> around for soundcard.h anymore in favor of libao. I've resisted removing >> ux_audio_oss.c entirely because I'd like to someday reenable that for older >> machines and massage it into something for older Sun workstations. > > Thank you. Is there any quick way to test if sound is working? I have a couple sound-using games that should suffice. https://661.org/proj/if/uninvited/uninvited.zblorb https://661.org/proj/if/oldcode/soundtest.blb The first is a reimplementation of Uninvited (https://en.wikipedia.org/wiki/Uninvited_(video_game)) and the second is intended to quickly and easily test all of Frotz's audio capabilities. > What about that ncursesw thing? I think it is NetBSD-specific? It might be. The distinction between old BSD curses and ncurses has been a source of problems over the years. I'm puzzled as to why it would complain there because I went over curses stuff repeatedly with all the BSDs prior to releasing 2.50 and it still compiles fine outside of the ports system. >> How is this patch supposed to be applied? > > Just like as you did. Can you check if your ports tree is up to date? > > The Makefile should have the following line: > > # $FreeBSD: head/games/frotz/Makefile 442400 2017-06-02 15:43:42Z sunpoet $ > > If 442400 is a lower number, the ports tree needs updating, the way > to do it depends on the way you got it (I have used the portsnap method): > > https://www.freebsd.org/doc/handbook/ports-using.html That's the same top line that I have. I updated it with Subversion. After fixing them by hand, I noticed that the patch zeroed out patch-src_curses_ux__audio__oss.c instead of deleting it. That caused a complaint from the ports Makefile. After manually deleting that, I got the same error you did. So, now we're sort of on the same page. I'll prod at this over the next couple days. NetBSD already has 2.50 commited. Maybe borrowing from there will work. -- David Griffith dave@661.org A: Because it fouls the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?