From owner-freebsd-current@FreeBSD.ORG Fri Sep 23 20:24:38 2005 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6614C16A420; Fri, 23 Sep 2005 20:24:38 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE46D43D48; Fri, 23 Sep 2005 20:24:37 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: from [10.50.41.233] (Not Verified[10.50.41.233]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Fri, 23 Sep 2005 16:40:30 -0400 From: John Baldwin To: Doug Barton Date: Fri, 23 Sep 2005 16:21:13 -0400 User-Agent: KMail/1.8 References: <1127245262.32486.1.camel@akima.flintsbach.schmalzbauer.de> <200509211738.42593.jhb@FreeBSD.org> <4333A6F7.1060400@FreeBSD.org> In-Reply-To: <4333A6F7.1060400@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200509231621.14965.jhb@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, Harald Schmalzbauer Subject: Re: nvidia kld panic with debug kernel X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2005 20:24:38 -0000 On Friday 23 September 2005 02:55 am, Doug Barton wrote: > John Baldwin wrote: > > On Wednesday 21 September 2005 05:28 pm, Harald Schmalzbauer wrote: > >>Am Mittwoch, 21. September 2005 22:51 CEST schrieb John Baldwin: > >>>On Tuesday 20 September 2005 03:41 pm, Harald Schmalzbauer wrote: > >>>>Hello, > >>>> > >>>>I get the following panic when using the nvidia driver with a debug > >>>>kernel, when I disable INVARIANTS and WITNESS everything is working > >>>>fine! > >>>> > >>>>Here's the trace: > >>>> > >>>>ACPI APIC Table: > >>>>ioapic0: Changing APIC ID to 1 > >>>>ioapic0 irqs 0-23 on motherboard > >>>>panic: spin lock rm.mutex_mtx not in order list > >>> > >>>You need to add an entry for "rm.mutex_mtx" to the static spin lock > >>>order list in sys/kern/subr_witness.c. Something like this: > >>> > >>>Index: subr_witness.c > >>>=================================================================== > >>>RCS file: /usr/cvs/src/sys/kern/subr_witness.c,v > >>>retrieving revision 1.201 > >>>diff -u -r1.201 subr_witness.c > >>>--- subr_witness.c 15 Sep 2005 19:07:14 -0000 1.201 > >>>+++ subr_witness.c 21 Sep 2005 20:50:45 -0000 > >>>@@ -363,6 +363,7 @@ > >>> #ifdef SMP > >>> { "ap boot", &lock_class_mtx_spin }, > >>> #endif > >>>+ { "rm.mutex_mtx", &lock_class_mtx_spin }, > >>> { "sio", &lock_class_mtx_spin }, > >>> #ifdef __i386__ > >>> { "cy", &lock_class_mtx_spin }, > >> > >>Thanks for your attention! I don't exactly know what this does and why I > >>should add this spinlock exclude, I posted this error because somewhere > >>between early BETA4 and late BETA4 I could run the nvidia driver with > >>debug kernels without this panic. Short before BETA5 this changed back to > >>the panic I've already seen before BETA4, so I posted it here. > >>If it is something harmless it's safe to ignore my post, if it's > >> something which reflects a bug I hope I could help. > > > > It has to do with the WITNESS kernel option. WITNESS has to be > > explicitly told about each spin mutex in the kernel. > > Would having this in the base adversely affect those who don't use the > driver? In other words, is there any reason not to just add this? No, and I'll happily commit it as soon as I get a report that the patch fixes the problem. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org