From owner-freebsd-bugs@FreeBSD.ORG Tue Jun 10 09:20:04 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0449A1065675 for ; Tue, 10 Jun 2008 09:20:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E89868FC1D for ; Tue, 10 Jun 2008 09:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5A9K3SZ025752 for ; Tue, 10 Jun 2008 09:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5A9K3Ae025751; Tue, 10 Jun 2008 09:20:03 GMT (envelope-from gnats) Date: Tue, 10 Jun 2008 09:20:03 GMT Message-Id: <200806100920.m5A9K3Ae025751@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Garrett Cooper" Cc: Subject: Re: bin/124409: Bug by design in getfsfile(3) / needed sanity check for mountpoints X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2008 09:20:04 -0000 The following reply was made to PR bin/124409; it has been noted by GNATS. From: "Garrett Cooper" To: bug-followup@freebsd.org Cc: Subject: Re: bin/124409: Bug by design in getfsfile(3) / needed sanity check for mountpoints Date: Mon, 9 Jun 2008 18:46:49 -0700 On Mon, Jun 9, 2008 at 5:55 PM, Giorgos Keramidas wrote: > On Tue, 10 Jun 2008 03:53:41 +0300, Giorgos Keramidas wrote: >> On Mon, 9 Jun 2008 01:34:19 -0700, "Garrett Cooper" wrote: >>> Hi hackers, >>> I have a question, pending a bug found in getfsfile(3) [1]. >>> Is there any possibility where a mountpoint be any value other >>> than a directory, a symlink, or "none", i.e. a flat file? >>> Thanks, >>> -Garrett >>> >>> References: >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/124409 (not fully in PR >>> database yet). >> >> It looks like could be 'fixed' by using realpath() on its argument. >> Then this should work fine: >> >> # fsck /usr/ > > I meant to write "It looks like getfsfile() could be 'fixed'...", but > the keyboard daemon ate a word there. Right. I'm just awaiting a quorum decision on hackers@ because I don't want to break existing functionality over what I think is correct. -Garrett