Date: Wed, 2 Apr 2003 20:44:14 +0200 From: Maxime Henrion <mux@freebsd.org> To: Nate Lawson <nate@root.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpreg.h if_fxpvar.h Message-ID: <20030402184414.GL1750@elvis.mu.org> In-Reply-To: <Pine.BSF.4.21.0304021020580.11936-100000@root.org> References: <20030402164726.ACB6737B401@hub.freebsd.org> <Pine.BSF.4.21.0304021020580.11936-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson wrote: > On Wed, 2 Apr 2003, Maxime Henrion wrote: > > Modified files: > > sys/dev/fxp if_fxp.c if_fxpreg.h if_fxpvar.h > > Log: > > Convert the fxp(4) driver to the busdma API. > > > > This patch is rather big because I had to significantly redesign > > the driver to make the busdma conversion possible. Most notably, > > hardware and software structures were carefully splitted to get > > rid of all the structs overlapping evilness. > > Nice! I have some locking patches for fxp that I'll post soon. It looks > like some nice comments were removed in your diff. It would be good if > you rewrote equivalent ones based on the change in behavior. I can't figure out which comments your are talking about. Some comments have been moved to other places where they belong now, and one comment has been removed in if_fxpreg.h because it wasn't meaningful anymore. Cheers, Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030402184414.GL1750>