From owner-cvs-all@FreeBSD.ORG  Wed Apr  2 10:44:15 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 50CD837B401; Wed,  2 Apr 2003 10:44:15 -0800 (PST)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D757643FB1; Wed,  2 Apr 2003 10:44:14 -0800 (PST)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id BC3F62ED416; Wed,  2 Apr 2003 10:44:14 -0800 (PST)
Date: Wed, 2 Apr 2003 20:44:14 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20030402184414.GL1750@elvis.mu.org>
References: <20030402164726.ACB6737B401@hub.freebsd.org>
	<Pine.BSF.4.21.0304021020580.11936-100000@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.BSF.4.21.0304021020580.11936-100000@root.org>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpreg.h if_fxpvar.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Apr 2003 18:44:15 -0000

Nate Lawson wrote:
> On Wed, 2 Apr 2003, Maxime Henrion wrote:
> >   Modified files:
> >     sys/dev/fxp          if_fxp.c if_fxpreg.h if_fxpvar.h 
> >   Log:
> >   Convert the fxp(4) driver to the busdma API.
> >   
> >   This patch is rather big because I had to significantly redesign
> >   the driver to make the busdma conversion possible.  Most notably,
> >   hardware and software structures were carefully splitted to get
> >   rid of all the structs overlapping evilness.
> 
> Nice!  I have some locking patches for fxp that I'll post soon.  It looks
> like some nice comments were removed in your diff.  It would be good if
> you rewrote equivalent ones based on the change in behavior.

I can't figure out which comments your are talking about.  Some comments
have been moved to other places where they belong now, and one comment
has been removed in if_fxpreg.h because it wasn't meaningful anymore.

Cheers,
Maxime