Date: Sun, 31 Mar 2013 12:16:41 -0400 From: Eitan Adler <eadler@freebsd.org> To: Bryan Drewery <bdrewery@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Chris Rees <crees@freebsd.org>, Joe Marcus Clarke <marcus@freebsd.org>, Niclas Zeising <zeising@freebsd.org>, =?UTF-8?Q?Beat_G=C3=A4tzi?= <beat@freebsd.org> Subject: Re: svn commit: r315624 - head/net/wireshark Message-ID: <CAF6rxgnwExQOwa5dNZ2SmcW4wxm9PXJrLU6LRpyGs2ApFF%2BcaQ@mail.gmail.com> In-Reply-To: <5158602E.7070101@FreeBSD.org> References: <201303302045.r2UKj1wS062090@svn.freebsd.org> <51575F46.3050807@freebsd.org> <CADLo838MFRnUrNQTv1Fo1r97zcRQceH-s2KDyqJwZY7gtMJetw@mail.gmail.com> <5158602E.7070101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31 March 2013 12:11, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 3/31/2013 11:02 AM, Chris Rees wrote: >> On 30 March 2013 21:55, Niclas Zeising <zeising@freebsd.org> wrote: >>> On 03/30/13 21:45, Joe Marcus Clarke wrote: >>>> Author: marcus >>>> Date: Sat Mar 30 20:45:00 2013 >>>> New Revision: 315624 >>>> URL: http://svnweb.freebsd.org/changeset/ports/315624 >>>> >>>> Log: >>>> Make pkgconfig an explicit dependency of tshark. >>>> >>>> Modified: >>>> head/net/wireshark/Makefile >>>> >>>> Modified: head/net/wireshark/Makefile >>>> ============================================================================== >>>> --- head/net/wireshark/Makefile Sat Mar 30 18:54:34 2013 (r315623) >>>> +++ head/net/wireshark/Makefile Sat Mar 30 20:45:00 2013 (r315624) >>>> @@ -75,7 +75,7 @@ USE_GNOME+= gtk20 >>>> WIRESHARK_LIBS+=${PTHREAD_LIBS} >>>> .else >>>> PLIST_SUB+= WIRESHARK="@comment wireshark not built" >>>> -USE_GNOME+= glib20 >>>> +USE_GNOME+= glib20 pkgconfig >>>> CONFIGURE_ARGS+= --enable-wireshark=no \ >>>> --disable-gtktest >>>> .endif >>>> >>> >>> You should use USE_PKGCONFIG=build instead. >>> >>> A completely other thing: >>> Isn't the ports tree frozen these days and require a Approved by: >>> portmgr line in the commit msg? Perhaps something isn't working as it >>> should there. >>> Regards! >> >> Those hooks are not working at the moment, though I don't remember if >> I specifically told Beat about it or just complained. >> >> I've copied him in just in case he didn't know. >> >> Another example: >> >> http://svnweb.freebsd.org/ports/svnadmin/conf/access?revision=314635&view=markup >> >> Chris >> > > The hook is working. portmgr are explicitly exempt from the check for > "Approved by". See svnadmin/hooks/scripts/approvecheck.pl To reduce confusion can we remove this? portmgr can use "Approved by: portmgr (implicit)" -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnwExQOwa5dNZ2SmcW4wxm9PXJrLU6LRpyGs2ApFF%2BcaQ>