From owner-freebsd-stable@FreeBSD.ORG Mon Aug 18 16:55:23 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50B6B106567B for ; Mon, 18 Aug 2008 16:55:23 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.229]) by mx1.freebsd.org (Postfix) with ESMTP id 16B268FC14 for ; Mon, 18 Aug 2008 16:55:23 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so3443662rvf.43 for ; Mon, 18 Aug 2008 09:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=X2jUWpJVh9TBD3NLixdau0VN/qEX9BWgNR92m8aZaYY=; b=bKUfevuc63ZXuy7M3yzUzqJ0P+ZHU7AfloMhkg08jEGyocokdOVu5pxpYwCjVi6t5U 1Ewx78eNiQ57s8vpRMMGR9uDsfRaF3xpeRIUv/DBt7aZmhwM4uuv2Vg3caluPyYwgG6f R/sbHiE2fLtaNy+uTYLtPjWxPSKp6EOuu2K4E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=XOvz0KYL3wEEt2d+u3qb8Lge7c7U7lP5/CX4IWvpJNad5G7W+i+wjuVjhKW3DOCOVQ S8A1eJve4ojFlctKF/27zjq1fjPEKTrxnc8ScXYdNwfrWYDTX3TAPn2d1raW+IoyRnkN LNHVpuahT7J5SHpFSVh0V6NRTHNiiKzRdek2M= Received: by 10.141.76.1 with SMTP id d1mr3416633rvl.269.1219078522556; Mon, 18 Aug 2008 09:55:22 -0700 (PDT) Received: by 10.141.101.21 with HTTP; Mon, 18 Aug 2008 09:55:22 -0700 (PDT) Message-ID: <3c1674c90808180955w665476e0s9f37321cfcfd1eed@mail.gmail.com> Date: Mon, 18 Aug 2008 09:55:22 -0700 From: "Kip Macy" Sender: mat.macy@gmail.com To: "Mike Tancsa" In-Reply-To: <200808181622.m7IGM9mk067285@lava.sentex.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200808181337.m7IDbqSC066670@lava.sentex.ca> <200808181024.40038.jhb@freebsd.org> <200808181622.m7IGM9mk067285@lava.sentex.ca> X-Google-Sender-Auth: b2da15e9c591f36d Cc: Robert Watson , freebsd-stable@freebsd.org, John Baldwin Subject: Re: HEADS UP: inpcb/inpcbinfo rwlocking: coming to a 7-STABLE branch near you X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2008 16:55:23 -0000 got it On Mon, Aug 18, 2008 at 9:22 AM, Mike Tancsa wrote: > At 10:24 AM 8/18/2008, John Baldwin wrote: > >> > Edit src/sys/conf/files >> > Add delta 1.1243.2.32 2008.07.30.20.35.41 kmacy >> > Edit src/sys/netinet/tcp_subr.c >> > Add delta 1.300.2.4 2008.07.30.20.35.41 kmacy >> > Edit src/sys/netinet/tcp_syncache.c >> > Add delta 1.130.2.9 2008.07.30.20.35.41 kmacy >> > Add delta 1.130.2.10 2008.07.30.20.51.20 kmacy >> > Edit src/sys/netinet/tcp_syncache.h >> > Add delta 1.1.2.1 2008.07.30.20.35.41 kmacy >> > Edit src/sys/netinet/tcp_usrreq.c >> > Add delta 1.163.2.4 2008.07.30.20.35.41 kmacy >> >> These are changes by Kip to do TCP offload (181013, 181014). >> >> Given that, I think the likeliest changes to cause this are the TCP >> offload >> changes. Note that Kip later MFC'd this change which changed ARP stuff: >> >> However, I would stary by narrowing it down to see if Kip's commits cause >> the >> change. > > > As I dont have the skills to unwind Robert's patch, I have done the > following > > csup with date=2008.08.01.00.00.00 > > which shows the problem. I then manually grabbed the prior versions of the > above files > > 0[smtp2]% ident src/sys/conf/files > src/sys/conf/files: > $FreeBSD: src/sys/conf/files,v 1.1243.2.30 2008/07/25 17:46:01 jhb Exp $ > 0[smtp2]% ident src/sys/netinet/tcp_subr.c > src/sys/netinet/tcp_subr.c: > $FreeBSD: src/sys/netinet/tcp_subr.c,v 1.300.2.3 2008/07/24 01:13:22 > julian Exp $ > 0[smtp2]% ident src/sys/netinet/tcp_syncache.c > src/sys/netinet/tcp_syncache.c: > $FreeBSD: src/sys/netinet/tcp_syncache.c,v 1.130.2.8 2008/07/24 01:13:22 > julian Exp $ > 0[smtp2]% ident src/sys/netinet/tcp_syncache.h > src/sys/netinet/tcp_syncache.h: > $FreeBSD: src/sys/netinet/tcp_syncache.h,v 1.1 2007/07/27 00:57:06 silby > Exp $ > 0[smtp2]% ident src/sys/netinet/tcp_usrreq.c > src/sys/netinet/tcp_usrreq.c: > $FreeBSD: src/sys/netinet/tcp_usrreq.c,v 1.163.2.3 2008/03/01 11:50:00 > rwatson Exp $ > 0[smtp2]% > > All is OK. So it looks like the above introduced the bug. > > ---Mike >