Date: Sat, 7 Jun 2014 22:53:50 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: Julio Merino <jmmv@freebsd.org>, FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Turning TESTS on by default Message-ID: <20140607195350.GU3991@kib.kiev.ua> In-Reply-To: <CAOtMX2ggB5wWgBCzkV5S2W1LfrFHC1YJE%2BTiSZOiwbWH7P=FEg@mail.gmail.com> References: <CAFY7cWB=BOKWh4gK=wwgvhnAoVUuVBOEqk08nXeo7eWwMguZzw@mail.gmail.com> <20140607033334.GO3991@kib.kiev.ua> <CAOtMX2ggB5wWgBCzkV5S2W1LfrFHC1YJE%2BTiSZOiwbWH7P=FEg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--DHnhIMemoiGGMQp1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 07, 2014 at 12:31:01PM -0600, Alan Somers wrote: > On Fri, Jun 6, 2014 at 9:33 PM, Konstantin Belousov <kostikbel@gmail.com>= wrote: > > On Fri, Jun 06, 2014 at 03:14:52PM -0400, Julio Merino wrote: > >> Hello all, > >> > >> > >> TL;DR > >> ----- > >> > >> I plan to turn the TESTS src.conf knob ON by default on Tuesday once I > >> have been able to perform enough sanity-checks of the build and all of > >> them pass. > >> > >> The impact of this is that the FreeBSD Test Suite (see tests(7)) will > >> be built and installed by default under /usr/tests/ along with the > >> private atf libraries and binaries. There should be no other changes > >> and this should be transparent to everyone. > >> > >> If this happens to break the world in any way, we can trivially roll > >> the change back to fix the fallout. > >> > >> > >> Some details > >> ------------ > >> > >> TESTS was never intended to be disabled by default. However, the > >> original patches that were committed months ago related to this > >> feature broke the build and the easiest way out (instead of reverting > >> the commits) was to set the knob to disabled. Unfortunately, it stayed > >> that way even after the discovered problems were fixed. > >> > >> I am confident enough now that we have ironed out all major issues > >> that this might introduce, so it is about time to enable TESTS by > >> default again in HEAD. > >> > >> The benefits of this are that 1) we allow end users (especially > >> consumers of binary releases!) to run the tests out of the box, as it > >> has always been intended; and 2) we will be able to run the official > >> release builds through testing via Jenkins, instead of having to issue > >> custom builds. > > This is very weird and unprobable. Users cannot care less about running > > the test suite, they use OS to run applications. IMO enabling installa= tion > > of the stuff that bloats the system but have no practical use for the > > system consumer should not be allowed by default. >=20 > I disagree. Sure, some users won't care. Probably even most users > won't care. But some of our users are active supporters of FreeBSD. > They evangelize, they file PRs, and they help other users on the > forums. Those users will run the tests. Some of them will find bugs > that we didn't, because they'll be using different hardware and > different configurations. Plus, shipping a test suite exudes an aura > of quality (if the tests pass, that is). So I think that we should > install the tests, but in a separate installation set, just like > games. I would agree with your arguments, and in fact not bother with the proposal at all, if most systems were installed using installer. I am very much confident that significant part of the population is installed or updated using make build/installworld. If somebody cares to run tests, she certainly cares enough to be able to turn the knob on. Otherwise, the tests take sometimes precious space on / or /usr, for nothing. Could somebody point out a popular software system that spills the tests or other developer-only[*] stuff into the production install ? I immediately remember the perl and its modules which have very extensive test suite, but the test suite is not installed. [*] As is, developers of the system, not developers utilizing the product as the base. --DHnhIMemoiGGMQp1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTk23OAAoJEJDCuSvBvK1BewUP/Az3+X3/n5Qfw6GRxJnwAf+v pYxtSkwCqjd/UeejwK1X/Lx1OdRTrQMpCFSC4QkT7K2bNg8AUUjqW1/v72zFaQMu uKYylM4dyuDx/+rxXWkTGkDnygiszymWSKJJZr8dg05bGrpK+BDSwlPL8uV15kOZ wyJYX42HDTFLuxYKx1FBW6Cn64h8Qz8Y0daWDV9YLvP7EaDIkyV8aHGT4biNGn2R yH6ijUGJA2XbJ+zVRYo9iSzeeohNJh+0ACQaxMYa8kZ7d1BTaLZaPmzAgxcKOxEG xheY7UOjKqDodVEICGAG8XNDIZL8q6V/zZ4wCPj3rJ5NA2I2Npl88N0MrqKJ4aWN L7DNVKJ02yZtZ8SAdS6JKOsQ4z4qvJAcXoYMO1MD7bgvj2uGUiTNnhWpky1Khy+v yW1eBq54E2Qobne3Ly8V35i4zWFNRGDTyahMpTN1VFzlI9BudPjEVDEHYAWYIrqI fg7cHiLGBpAVzxJl2PocRhU6+1kbZYEdMcYmGp8d7pjvlidMjg0O2sxdUD9dijb6 LYTLCsb2PRDQskO0QgmhEmNIVIDsbgmAEjakZ5tt4Rq27AKjm/Rsyl2nN0N4ztxj RWfLWiISxWcU+IXDR7TedR+cTuC8k1pWbyCyY89ewefOWAKWnQFbuExadceQpwbg wsXEj8zub+gERRxOkeZk =VFM4 -----END PGP SIGNATURE----- --DHnhIMemoiGGMQp1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140607195350.GU3991>