From owner-svn-src-projects@freebsd.org Wed Jul 25 03:10:56 2018 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3DB4C103BF79 for ; Wed, 25 Jul 2018 03:10:56 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA1E08C0B7; Wed, 25 Jul 2018 03:10:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 7C5BA191D5; Wed, 25 Jul 2018 03:10:55 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f43.google.com with SMTP id f18-v6so4380852lfc.2; Tue, 24 Jul 2018 20:10:55 -0700 (PDT) X-Gm-Message-State: AOUpUlHqhhOXOJ4Pi4fobVnmHfTxOkY3IGr7ze2Jpud/X3QuauLjQwiz tUjdQ76c99zNSZdw4sDYu/4vf007WGjiKDU6tDY= X-Google-Smtp-Source: AAOMgpdVmSs1JhabGyf5HO6ckuzYcxYfT/8+Y8ph/qx8WBrloOBKlXqsAs+KE64Jdw8Ro+XHRWNTQ/H9XlQFan1Hsyw= X-Received: by 2002:a19:7b08:: with SMTP id w8-v6mr2606403lfc.22.1532488253689; Tue, 24 Jul 2018 20:10:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Tue, 24 Jul 2018 20:10:33 -0700 (PDT) In-Reply-To: <201807250308.w6P38Bub063668@repo.freebsd.org> References: <201807250308.w6P38Bub063668@repo.freebsd.org> From: Kyle Evans Date: Tue, 24 Jul 2018 22:10:33 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r336696 - projects/bectl/lib/libbe To: Kyle Evans Cc: src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 03:10:56 -0000 On Tue, Jul 24, 2018 at 10:08 PM, Kyle Evans wrote: > Author: kevans > Date: Wed Jul 25 03:08:11 2018 > New Revision: 336696 > URL: https://svnweb.freebsd.org/changeset/base/336696 > > Log: > libbe(3): Disambiguate 'active' a little bit, add 'bootfs' > > - Rename 'active' to 'rootfs', which is used in other places to describe the > currently booted (or about to be booted) BE. > > - Add 'bootfs', which indicates the next boot environment to be booted. This > is pulled from the BOOTFS zpool property. > > - Go ahead and keep an open handle to the active zpool. We might need to > enumerate datasets, get properties, and set properties (e.g. bootfs) > throughout other libbe bits, and a single handle isn't overly expensive. Subtract "enumerate datasets" from that list... that doesn't require a zpool handle. This does reduce redundancy in pulling out pool names to exactly one place we do this, and we'll clean this stuff up more later.