Date: Sat, 25 Jun 2005 09:42:29 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Maksim Yevmenkin <maksim.yevmenkin@savvis.net> Cc: freebsd-current@FreeBSD.org Subject: Re: [patch] ep(4) panic Message-ID: <20050625064229.GA56086@ip.net.ua> In-Reply-To: <42BCA0A0.8040902@savvis.net> References: <42BCA0A0.8040902@savvis.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 24, 2005 at 05:09:04PM -0700, Maksim Yevmenkin wrote: > Dear Hackers, >=20 > my -current panics when i insert ep(4) pcmcia network adapter. following= =20 > is the patch to fix the panic. >=20 > --- if_ep_pccard.c.orig Fri Jun 10 12:04:44 2005 > +++ if_ep_pccard.c Fri Jun 24 16:51:12 2005 > @@ -73,6 +73,7 @@ > struct ep_board *epb =3D &sc->epb; > const char *desc; > uint16_t result; > + u_char eaddr[6]; > int error; >=20 > error =3D ep_alloc(dev); > @@ -120,7 +121,7 @@ > * Newer cards supported by this device need to have their > * MAC address set. > */ > - error =3D ep_get_macaddr(sc, (u_char *)&IFP2ENADDR(sc->ifp)); > + error =3D ep_get_macaddr(sc, eaddr); >=20 > ep_free(dev); > return (0); >=20 That's odd. You're saving the MAC address nowhere (it's reused later). Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFCvPzVqRfpzJluFF4RAtMCAJ98EZGWrhy3kxgFPXd2MXeqhLFligCfTir0 TQzx2soIdEnmuual/MOwOeU= =OSCM -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050625064229.GA56086>