From owner-svn-src-head@FreeBSD.ORG  Thu Jan 15 18:53:44 2015
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 19CAD877;
 Thu, 15 Jan 2015 18:53:44 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E300BEF9;
 Thu, 15 Jan 2015 18:53:43 +0000 (UTC)
Received: from new-host-2.home (pool-173-70-85-31.nwrknj.fios.verizon.net
 [173.70.85.31])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id E1F41B91F;
 Thu, 15 Jan 2015 13:53:42 -0500 (EST)
Message-ID: <54B80CB6.5030102@FreeBSD.org>
Date: Thu, 15 Jan 2015 13:53:42 -0500
From: John Baldwin <jhb@FreeBSD.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>, Hans Petter Selasky <hps@selasky.org>
Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern
 sys/ofed/include/linux sys/sys
References: <201501151532.t0FFWV2Y037455@svn.freebsd.org>
 <54B7E287.80406@FreeBSD.org> <54B7E566.8050601@selasky.org>
 <20150115171430.GO15484@FreeBSD.org> <20150115171539.GP15484@FreeBSD.org>
In-Reply-To: <20150115171539.GP15484@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Thu, 15 Jan 2015 13:53:43 -0500 (EST)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, sbruno@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jan 2015 18:53:44 -0000

On 1/15/15 12:15 PM, Gleb Smirnoff wrote:
> On Thu, Jan 15, 2015 at 08:14:30PM +0300, Gleb Smirnoff wrote:
> T> I'd dare to say that such important change simply cannot be committed
> T> with a thorough review from at least two people very confident in this
> T> area.
> 
> Of course, I typoed. I meant "cannot be committed withOUT a thorough review".

There is something to be said for people taking time to review things
and not wanting to be held up forever.  However, I think it's been a
clear practice with all other changes reviewed in phabric to date that
the committer only lists people in 'Reviewed by' who actually signed off
on the patch, not just the list of people asked to review it.

-- 
John Baldwin