From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Feb 20 15:30:04 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F51C16A40D for ; Wed, 20 Feb 2008 15:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5746013C458 for ; Wed, 20 Feb 2008 15:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1KFU4rS030607 for ; Wed, 20 Feb 2008 15:30:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1KFU4cY030604; Wed, 20 Feb 2008 15:30:04 GMT (envelope-from gnats) Resent-Date: Wed, 20 Feb 2008 15:30:04 GMT Resent-Message-Id: <200802201530.m1KFU4cY030604@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, dmx@dmx.org.ru Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B63BE16A401 for ; Wed, 20 Feb 2008 15:26:45 +0000 (UTC) (envelope-from dmx@tiger.tehnopark.org) Received: from tiger.tehnopark.org (ul198.informika.ru [194.226.214.198]) by mx1.freebsd.org (Postfix) with ESMTP id 34E3713C459 for ; Wed, 20 Feb 2008 15:26:44 +0000 (UTC) (envelope-from dmx@tiger.tehnopark.org) Received: from tiger.tehnopark.org (localhost.tehnopark.org [127.0.0.1]) by tiger.tehnopark.org (8.13.8/8.13.8) with ESMTP id m1KElAG8088278 for ; Wed, 20 Feb 2008 17:47:10 +0300 (MSK) (envelope-from dmx@tiger.tehnopark.org) Received: (from root@localhost) by tiger.tehnopark.org (8.13.8/8.13.8/Submit) id m1KElA9N088277; Wed, 20 Feb 2008 17:47:10 +0300 (MSK) (envelope-from dmx) Message-Id: <200802201447.m1KElA9N088277@tiger.tehnopark.org> Date: Wed, 20 Feb 2008 17:47:10 +0300 (MSK) From: dmx@dmx.org.ru To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/120885: [patch] security/clamav. During install process, created work dirs have wrong permissions X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dmx@dmx.org.ru List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2008 15:30:04 -0000 >Number: 120885 >Category: ports >Synopsis: [patch] security/clamav. During install process, created work dirs have wrong permissions >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 20 15:30:03 UTC 2008 >Closed-Date: >Last-Modified: >Originator: dmx@dmx.org.ru >Release: FreeBSD 6.2-STABLE amd64 >Organization: dmx@dmx.org.ru >Environment: System: FreeBSD tiger.tehnopark.org 6.2-STABLE FreeBSD 6.2-STABLE #1: Wed Apr 4 04:48:40 MSD 2007 root@tiger.tehnopark.org:/usr/obj/usr/src/sys/TIGER amd64 >Description: security/clamav port (clamav-0.92.1) With wrong umask before install, make install clamav port, directories (DBDIR, LOGDIR, RUNDIR) will be create with wrong permissions. >How-To-Repeat: Just set some umask (e.g. umask 0222) and run "make install" >Fix: --- pkg-install.in.orig Wed Mar 28 15:12:07 2007 +++ pkg-install.in Wed Feb 20 16:54:47 2008 @@ -13,8 +13,7 @@ RUNDIR=%%RUNDIR%% PW="pw" -CHOWN="chown" -MKDIR="mkdir -p" +MKDIR="install -v -d -m 0755 -o ${CLAMAVUSER} -g ${CLAMAVGROUP}" if [ "$2" = "PRE-INSTALL" ]; then @@ -42,14 +41,9 @@ elif [ "$2" = "POST-INSTALL" ]; then - [ ! -d "${DBDIR}" ] && (${MKDIR} ${DBDIR} || exit 1) - ${CHOWN} -R ${CLAMAVUSER}:${CLAMAVGROUP} ${DBDIR} || exit 1 - - [ ! -d "${LOGDIR}" ] && (${MKDIR} ${LOGDIR} || exit 1) - ${CHOWN} -R ${CLAMAVUSER}:${CLAMAVGROUP} ${LOGDIR} || exit 1 - - [ ! -d "${RUNDIR}" ] && (${MKDIR} ${RUNDIR} || exit 1) - ${CHOWN} -R ${CLAMAVUSER}:${CLAMAVGROUP} ${RUNDIR} || exit 1 + ${MKDIR} ${DBDIR} || exit 1 + ${MKDIR} ${LOGDIR} || exit 1 + ${MKDIR} ${RUNDIR} || exit 1 fi >Release-Note: >Audit-Trail: >Unformatted: