From owner-freebsd-current@FreeBSD.ORG Tue Feb 10 21:32:49 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 45A66CD6; Tue, 10 Feb 2015 21:32:49 +0000 (UTC) Received: from pmta1.delivery9.ore.mailhop.org (pmta1.delivery9.ore.mailhop.org [54.186.172.23]) by mx1.freebsd.org (Postfix) with ESMTP id 21221BA1; Tue, 10 Feb 2015 21:32:48 +0000 (UTC) Received: from smtp7.ore.mailhop.org (172.31.36.112) by pmta1.delivery1.ore.mailhop.org id hr9sfs20r84p; Tue, 10 Feb 2015 21:32:44 +0000 (envelope-from ) Received: from [73.34.117.227] (helo=ilsoft.org) by smtp7.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YLIQK-0000t1-LN; Tue, 10 Feb 2015 21:32:48 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t1ALWiQo083884; Tue, 10 Feb 2015 14:32:44 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1/jCToRnOoadjCacizGgD0r Message-ID: <1423603964.80968.28.camel@freebsd.org> Subject: Re: nagios vs w/uptime From: Ian Lepore To: Michael Gmelin Date: Tue, 10 Feb 2015 14:32:44 -0700 In-Reply-To: References: <54DA617A.4090309@wemm.org> <4A76A371-B573-4E62-BE78-94944963FFD0@freebsd.org> Content-Type: text/plain; charset="iso-8859-7" X-Mailer: Evolution 3.12.8 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: freebsd-current Current , Peter Wemm , Marcel Moolenaar X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 21:32:49 -0000 On Tue, 2015-02-10 at 22:24 +0100, Michael Gmelin wrote: > > > > On 10 Feb 2015, at 22:17, Michael Gmelin wrote: > > > > > > > > > >> On 10 Feb 2015, at 21:13, Marcel Moolenaar wrote: > >> > >> [Moving to current@] > >> > >>> On Feb 10, 2015, at 11:52 AM, Peter Wemm wrote: > >>> > >>> Surprises: > >>> * nagios doesn't like w / uptime anymore. libxo perhaps? > >> > >> Seems most likely, although I havenąt seen any differences in output > >> in my (admittedly limited) testing. > >> > >> In what way does Nagios not like w/uptime? > >> Any concrete errors, output or misbehavior? > >> Ideally: can you reproduce the problem? > > > > > > Just compared 10.1 to current, unmodified output looks the same, but pipelines don't work properly: > > > > 10.1: > > # uptime | wc > > 1 12 68 > > > > Current: > > # uptime | wc > > 0 0 0 > > > > # uptime | cat > > # uptime > > 10:16PM up 9 mins... > > > > Adding xo_finish() to w.c line 268 just right before exit(0); fixes that issue (I don't know libxo well enough to say if this is the proper fix or just a workaround, but it seems logical to me). > I wonder if that implies that any non-normal exit from a program that has been xo'd will result in the loss of output that would not have been lost before the xo changes? That could lead to all kinds of subtle failures of existing scripts and apps. -- Ian