From owner-svn-src-all@FreeBSD.ORG Tue Mar 31 16:17:29 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A5B87A0; Tue, 31 Mar 2015 16:17:29 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CE1AC59; Tue, 31 Mar 2015 16:17:29 +0000 (UTC) Received: from Julian-MBP3.local (ppp121-45-255-201.lns20.per4.internode.on.net [121.45.255.201]) (authenticated bits=0) by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t2VGHI6R019853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 31 Mar 2015 09:17:23 -0700 (PDT) (envelope-from julian@freebsd.org) Message-ID: <551AC889.2020708@freebsd.org> Date: Wed, 01 Apr 2015 00:17:13 +0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Randall Stewart , John Baldwin Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <32487399.PTq7ESkWJT@ralph.baldwin.cx> <26047F0C-A975-4DAC-9077-31B5EC4902DA@netflix.com> In-Reply-To: <26047F0C-A975-4DAC-9077-31B5EC4902DA@netflix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 16:17:29 -0000 On 3/31/15 8:26 AM, Randall Stewart wrote: > > On Mar 30, 2015, at 9:16 AM, John Baldwin > wrote: > >> On Saturday, March 28, 2015 12:50:24 PM Randall Stewart wrote: >>> Author: rrs >>> Date: Sat Mar 28 12:50:24 2015 >>> New Revision: 280785 >>> URL: https://svnweb.freebsd.org/changeset/base/280785 >>> >>> Log: >>> Change the callout to supply -1 to indicate we are not changing >>> CPU, also add protection against invalid CPU's as well as >>> split c_flags and c_iflags so that if a user plays with the active >>> flag (the one expected to be played with by callers in MPSAFE) >>> without >>> a lock, it won't adversely affect the callout system by causing a >>> corrupt >>> list. This also means that all callers need to use the macros and >>> *not* >>> play with the falgs directly (like netgraph used to). >>> >>> Differential Revision: htts://reviews.freebsd.org/D1894 >>> Reviewed by: .. timed out but looked at by jhb, imp, adrian hselasky >>> tested by hiren and netflix. >>> Sponsored by:Netflix Inc. >> >> Please use NOCPU rather than -1 directly for the CPU field when not >> moving a callout. >> > > John: > > I have made *all* of your suggested changes, adopting the comments and > moving migration to kern_timeout.c.. thanks.. > > Now as to the > > -1 -> NOCPU > > This is like pulling on a string on your sweater.. the only sensible > solution that > I could come up with after chatting with Lawrence is to add > #include > to everyone that uses the callout.h and does not have it already… > (putting it into callout.h does not work) .. sigh.. > > Now for this cosmetic change I end up with the following changes > (and as yet I have > not built LINT or universe so there may be more).. I have spent > about 2 hours on this > so far and I can at least build a kernel with the change for amd64 :-0 > > Here is what has to change, do you really think that this is worth it? > > Note I did not look into moving NOCPU in proc.h it says it means no > CPU is present > which is sort of the meaning we want.. I am not sure if the define > could be moved .. but > that too may be yet another string... sounds like NOCPU should be defined somewhere else. > > Is this worth it, or do you have another idea on how best to do this??? > > R > > ------