From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 22 21:26:46 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5D4E106566C; Mon, 22 Nov 2010 21:26:46 +0000 (UTC) (envelope-from bruce@cran.org.uk) Received: from muon.cran.org.uk (muon.cran.org.uk [IPv6:2a01:348:0:15:5d59:5c40:0:1]) by mx1.freebsd.org (Postfix) with ESMTP id 4F2878FC0A; Mon, 22 Nov 2010 21:26:46 +0000 (UTC) Received: from muon.cran.org.uk (localhost [127.0.0.1]) by muon.cran.org.uk (Postfix) with ESMTP id A1F3AE7215; Mon, 22 Nov 2010 21:26:45 +0000 (GMT) Received: from core.draftnet (client-86-29-107-54.glfd.adsl.virginmedia.com [86.29.107.54]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by muon.cran.org.uk (Postfix) with ESMTPSA; Mon, 22 Nov 2010 21:26:44 +0000 (GMT) Date: Mon, 22 Nov 2010 21:26:29 +0000 From: Bruce Cran To: Artem Belevich Message-ID: <20101122212629.2b19c1ec@core.draftnet> In-Reply-To: References: <20101122162712.3c3655fe@core.draftnet> <20101122183523.GA28412@freebsd.org> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.22.1; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexander Best , freebsd-hackers@freebsd.org Subject: Re: Logical vs. bitwise AND in sbin/routed/parms.c X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 21:26:46 -0000 On Mon, 22 Nov 2010 10:48:09 -0800 Artem Belevich wrote: > hdr.elf.e_ident[EI_OSABI] is not a bitmask and '==' should've been > used instead. Now ldd.c has two instances of this bug due to > copy/pasting of orignal code. Fixed in r215705. Thanks! -- Bruce Cran