Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 29 Jun 2015 17:40:05 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-fs@FreeBSD.org
Subject:   [Bug 168158] [zfs] incorrect parsing of sharenfs options in zfs (fsshare.c)
Message-ID:  <bug-168158-3630-uflssOsrbR@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-168158-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-168158-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=168158

eborisch+FreeBSD@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eborisch+FreeBSD@gmail.com

--- Comment #3 from eborisch+FreeBSD@gmail.com ---
Created attachment 158168
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=158168&action=edit
Patch to support hyphenated host names in sharenfs zfs property.

Simple patch that only ignores leading hyphens in options.

With this change:

    '-ro,a-server -alldirs' -> '-ro a-server -alldirs'

instead of (current behavior):

    '-ro,a-server -alldirs' -> '-ro a server -alldirs'

Changed by removing '-' from strsep() call, and handling (skipping) hyphen if
first character immediately after strsep() call.

All test cases listed immediately prior to the code still work; I'm not aware
of any supported forms that are broken by this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-168158-3630-uflssOsrbR>