From owner-freebsd-net@FreeBSD.ORG Wed Mar 31 14:05:37 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A981106566C; Wed, 31 Mar 2010 14:05:37 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from mail-pz0-f184.google.com (mail-pz0-f184.google.com [209.85.222.184]) by mx1.freebsd.org (Postfix) with ESMTP id C5AFC8FC14; Wed, 31 Mar 2010 14:05:35 +0000 (UTC) Received: by pzk14 with SMTP id 14so141344pzk.14 for ; Wed, 31 Mar 2010 07:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=yZgOMJlWpff4TKSXFRYdPkvqb9wD+ouPrdwJFDTXiYY=; b=jMT8XuLSEb48UuV8A5TlaDJpnlyoOmK5zMmGYi4B2GSyAJDLHweD0QoY+Z84wP8+lW oEAt47NnLBn99OHeCKpSEfqaRFwTXLb2vf5ZsuDZX2JL0HM8ka1kG81Fo4/g6MI8gysR qTVXIoCFRC/HFxktqk6BdTZxv1RAnTv6NJZmM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=tUuVTAtB4Gl4Indtbt1H32x/k6uyyq0n3HIDohK5E5H43gWY+uscInZHuw/wjXxp0Z a3saY7PfaV+QEUFZo3ctdE8xQhcoFCpHYovHX4QWoLbNe6aWU4CdvlMcAkvBm85D1Gex Pxb/ZNHVJ2gM9QPxq7LmxoL1DcjLLvW3taD08= Received: by 10.141.90.17 with SMTP id s17mr276996rvl.207.1270044333820; Wed, 31 Mar 2010 07:05:33 -0700 (PDT) Received: from [10.0.10.2] (54.81.54.77.rev.vodafone.pt [77.54.81.54]) by mx.google.com with ESMTPS id o38sm2256807rvp.15.2010.03.31.07.05.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 31 Mar 2010 07:05:32 -0700 (PDT) Sender: Rui Paulo Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <20100331140415.GB68231@mx.techwires.net> Date: Wed, 31 Mar 2010 15:05:27 +0100 Content-Transfer-Encoding: 7bit Message-Id: <47F572EE-B5E5-4961-81C5-179AD0F4A90A@freebsd.org> References: <63B143BF-20C9-425F-8969-B7452191E84F@freebsd.org> <20100331140415.GB68231@mx.techwires.net> To: Bernhard Schmidt X-Mailer: Apple Mail (2.1078) Cc: freebsd-net , Antoine Brodin Subject: Re: net80211 ratectl proof of concept X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2010 14:05:37 -0000 On 31 Mar 2010, at 15:04, Bernhard Schmidt wrote: > On Wed, Mar 31, 2010 at 02:31:30PM +0100, Rui Paulo wrote: >> On 31 Mar 2010, at 14:24, Antoine Brodin wrote: >>> This looks great! >>> Is there specific reasons to use pointers and not ints for some >>> arguments of foo_tx_complete() and foo_tx_update()? >> >> Not really. I'll probably switch them to ints at some point. > > Hmm, I somehow like the idea of not passing integers here. Looking at > ath_rate/sample it passes a struct. I don't know whether this can be > rewritten though. It can be rewritten to pass ints, from what I understand. -- Rui Paulo